Re: [PATCH] Add support for ordered list to ox-confluence.el

[Lungang Fang <lungang.fang@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2972 bytes --]

Great! Then, what about using my patch ? It would be my first patch adopted
by any open source project, a real milestone  :)

On Friday, December 9, 2016, Charles Durst <cwdurst+orgmode@gmail.com>
wrote:

> I have tried the results of both versions and loaded them into the
> Confluence Wiki, and Lungang is correct, from what I can tell, they
> both will work.
>
> So I don't really care which one you choose either.  I just needed the
> functionality.
> --
> Charles Durst
> cwdurst+orgmode@gmail.com <javascript:;>
>
> On Thu, Dec 8, 2016 at 9:32 PM, Lungang Fang <lungang.fang@gmail.com
> <javascript:;>> wrote:
> > Hi Charles and Nicholas,
> >
> > My code also supports nested mixed lists but is simpler. I mean, my code
> > will convert the list given by Charles to
> >
> > # Here
> > -- is
> > -- an
> > # example
> > -- of
> > -- a
> > # mixed
> > # list
> >
> > Although this format is not mentioned in confluence wiki, it is
> supported by
> > conflucence according to my test (in Jira).
> >
> > So, in my opinion, it is a matter of personal preference: more
> complicated
> > code complies with documented interface, or simpler code that exploits
> > undocumented feature.
> >
> > I prefer my code. But you guys feel free to make decision. I am OK with
> > whatever you choose.
> >
> > Cheers,
> > Lungang
> >
> > On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst <
> cwdurst+orgmode@gmail.com <javascript:;>>
> > wrote:
> >>
> >> They do conflict.  My version is slightly more complicated since it
> >> also supports nested mixed lists.
> >>
> >> For example:
> >>
> >> 1. Here
> >>    * is
> >>    * an
> >> 2. example
> >>    * of
> >>    * a
> >> 3. mixed
> >> 4. list
> >>
> >> Which translates to:
> >>
> >> # Here
> >> #- is
> >> #- an
> >> # example
> >> #- of
> >> #- a
> >> # mixed
> >> # list
> >>
> >> Which is effectively the same as the example in the Confluence
> >> documentation:
> >>
> >> https://confluence.atlassian.com/confcloud/confluence-wiki-
> markup-724765099.html#ConfluenceWikiMarkup-Mixedlists
> >>
> >> --
> >> Charles Durst
> >> cwdurst+orgmode@gmail.com <javascript:;>
> >>
> >>
> >> On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr
> <javascript:;>>
> >> wrote:
> >> > Hello,
> >> >
> >> > Lungang Fang <lungang.fang@gmail.com <javascript:;>> writes:
> >> >
> >> >> Attached is a patch for contrib/lisp/ox-confluence.el generated
> >> >> following
> >> >> instructions on http://orgmode.org/worg/org-contribute.html#patches
> .
> >> >> It
> >> >> adds support for ordered list.
> >> >
> >> > Thank you.
> >> >
> >> > However, this somewhat conflicts with a patch recently sent on the ML,
> >> > but not yet applied, by Charles Durst (Cc'ed).
> >> >
> >> > Could one double-check if one doesn't supersede the other, or if they
> >> > could be merged (although I suspect the former) and report back so
> >> > I know what patch to apply?
> >> >
> >> > Regards,
> >> >
> >> > --
> >> > Nicolas Goaziou
> >
> >
>

[-- Attachment #2: Type: text/html, Size: 4787 bytes --]