From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lungang Fang Subject: Re: [PATCH] Add support for ordered list to ox-confluence.el Date: Fri, 9 Dec 2016 19:34:32 +1100 Message-ID: References: <87pol2f34e.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1143b2a68d80d00543359fed Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFGea-0004Dj-8k for emacs-orgmode@gnu.org; Fri, 09 Dec 2016 03:35:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFGeT-0007Hf-Hx for emacs-orgmode@gnu.org; Fri, 09 Dec 2016 03:35:40 -0500 Received: from mail-qt0-f178.google.com ([209.85.216.178]:36629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFGeT-0007HV-DG for emacs-orgmode@gnu.org; Fri, 09 Dec 2016 03:35:33 -0500 Received: by mail-qt0-f178.google.com with SMTP id w33so9922333qtc.3 for ; Fri, 09 Dec 2016 00:35:33 -0800 (PST) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "cwdurst+orgmode@gmail.com" , emacs-orgmode@gnu.org --001a1143b2a68d80d00543359fed Content-Type: text/plain; charset=UTF-8 Great! Then, what about using my patch ? It would be my first patch adopted by any open source project, a real milestone :) On Friday, December 9, 2016, Charles Durst wrote: > I have tried the results of both versions and loaded them into the > Confluence Wiki, and Lungang is correct, from what I can tell, they > both will work. > > So I don't really care which one you choose either. I just needed the > functionality. > -- > Charles Durst > cwdurst+orgmode@gmail.com > > On Thu, Dec 8, 2016 at 9:32 PM, Lungang Fang > wrote: > > Hi Charles and Nicholas, > > > > My code also supports nested mixed lists but is simpler. I mean, my code > > will convert the list given by Charles to > > > > # Here > > -- is > > -- an > > # example > > -- of > > -- a > > # mixed > > # list > > > > Although this format is not mentioned in confluence wiki, it is > supported by > > conflucence according to my test (in Jira). > > > > So, in my opinion, it is a matter of personal preference: more > complicated > > code complies with documented interface, or simpler code that exploits > > undocumented feature. > > > > I prefer my code. But you guys feel free to make decision. I am OK with > > whatever you choose. > > > > Cheers, > > Lungang > > > > On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst < > cwdurst+orgmode@gmail.com > > > wrote: > >> > >> They do conflict. My version is slightly more complicated since it > >> also supports nested mixed lists. > >> > >> For example: > >> > >> 1. Here > >> * is > >> * an > >> 2. example > >> * of > >> * a > >> 3. mixed > >> 4. list > >> > >> Which translates to: > >> > >> # Here > >> #- is > >> #- an > >> # example > >> #- of > >> #- a > >> # mixed > >> # list > >> > >> Which is effectively the same as the example in the Confluence > >> documentation: > >> > >> https://confluence.atlassian.com/confcloud/confluence-wiki- > markup-724765099.html#ConfluenceWikiMarkup-Mixedlists > >> > >> -- > >> Charles Durst > >> cwdurst+orgmode@gmail.com > >> > >> > >> On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou > > >> wrote: > >> > Hello, > >> > > >> > Lungang Fang > writes: > >> > > >> >> Attached is a patch for contrib/lisp/ox-confluence.el generated > >> >> following > >> >> instructions on http://orgmode.org/worg/org-contribute.html#patches > . > >> >> It > >> >> adds support for ordered list. > >> > > >> > Thank you. > >> > > >> > However, this somewhat conflicts with a patch recently sent on the ML, > >> > but not yet applied, by Charles Durst (Cc'ed). > >> > > >> > Could one double-check if one doesn't supersede the other, or if they > >> > could be merged (although I suspect the former) and report back so > >> > I know what patch to apply? > >> > > >> > Regards, > >> > > >> > -- > >> > Nicolas Goaziou > > > > > --001a1143b2a68d80d00543359fed Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Great! Then,=C2=A0what about using my patch ? It would be my first patch ad= opted by any open source project, a real milestone=C2=A0 :)

On Frida= y, December 9, 2016, Charles Durst <cwdurst+orgmode@gmail.com> wrote:
I have tried the results of both versions and loaded them into t= he
Confluence Wiki, and Lungang is correct, from what I can tell, they
both will work.

So I don't really care which one you choose either.=C2=A0 I just needed= the
functionality.
--
Charles Durst
cwdurst+orgmode@gmail.com

On Thu, Dec 8, 2016 at 9:32 PM, Lungang Fang <lung= ang.fang@gmail.com> wrote:
> Hi Charles and Nicholas,
>
> My code also supports nested mixed lists but is simpler. I mean, my co= de
> will convert the list given by Charles to
>
> # Here
> -- is
> -- an
> # example
> -- of
> -- a
> # mixed
> # list
>
> Although this format is not mentioned in confluence wiki, it is suppor= ted by
> conflucence according to my test (in Jira).
>
> So, in my opinion, it is a matter of personal preference: more complic= ated
> code complies with documented interface, or simpler code that exploits=
> undocumented feature.
>
> I prefer my code. But you guys feel free to make decision. I am OK wit= h
> whatever you choose.
>
> Cheers,
> Lungang
>
> On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst <cwdurst+orgmode@gmail.com>
> wrote:
>>
>> They do conflict.=C2=A0 My version is slightly more complicated si= nce it
>> also supports nested mixed lists.
>>
>> For example:
>>
>> 1. Here
>>=C2=A0 =C2=A0 * is
>>=C2=A0 =C2=A0 * an
>> 2. example
>>=C2=A0 =C2=A0 * of
>>=C2=A0 =C2=A0 * a
>> 3. mixed
>> 4. list
>>
>> Which translates to:
>>
>> # Here
>> #- is
>> #- an
>> # example
>> #- of
>> #- a
>> # mixed
>> # list
>>
>> Which is effectively the same as the example in the Confluence
>> documentation:
>>
>> https://confluence.atlassian.com/confcloud/confluence-wiki-mark= up-724765099.html#ConfluenceWikiMarkup-Mixedlists
>>
>> --
>> Charles Durst
>> cwdurst+orgmode@gmail.com
>>
>>
>> On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> wrote:
>> > Hello,
>> >
>> > Lungang Fang <lungang.fang@gmail.com= > writes:
>> >
>> >> Attached is a patch for contrib/lisp/ox-confluence.el gen= erated
>> >> following
>> >> instructions on http://orgmode.org/worg/org-c= ontribute.html#patches .
>> >> It
>> >> adds support for ordered list.
>> >
>> > Thank you.
>> >
>> > However, this somewhat conflicts with a patch recently sent o= n the ML,
>> > but not yet applied, by Charles Durst (Cc'ed).
>> >
>> > Could one double-check if one doesn't supersede the other= , or if they
>> > could be merged (although I suspect the former) and report ba= ck so
>> > I know what patch to apply?
>> >
>> > Regards,
>> >
>> > --
>> > Nicolas Goaziou
>
>
--001a1143b2a68d80d00543359fed--