From: York Zhao <gtdplatform@gmail.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Patch for testing `org-open-at-point'
Date: Thu, 10 Apr 2014 21:34:43 -0400 [thread overview]
Message-ID: <CAD3zm219Tu5tQLRB+ubmQ9_DMyScOzp1tXTfv6LauEFHR6YQRQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Hi,
I found a bug that `org-open-at-point' doesn't work if the link is a heading
property. This used to work and was broken recently. I have written a test for
this. The test is suppose to fail in current org-mode version. Please find
attached my patch for the test. Hopefully I I didn't place the test in the wrong
file.
York
[-- Attachment #2: 0001-test-org-element-Add-test-for-org-open-at-point-with.patch --]
[-- Type: text/x-diff, Size: 933 bytes --]
From df0788134a16baa9762616637c0fe7f568e3e63e Mon Sep 17 00:00:00 2001
From: York Zhao <gtdplatform@gmail.com>
Date: Thu, 10 Apr 2014 21:21:15 -0400
Subject: [PATCH] test-org-element: Add test for `org-open-at-point' with link
being heading property.
---
testing/lisp/test-org-element.el | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/testing/lisp/test-org-element.el b/testing/lisp/test-org-element.el
index 576e3d3..8cfceac 100644
--- a/testing/lisp/test-org-element.el
+++ b/testing/lisp/test-org-element.el
@@ -1461,6 +1461,15 @@ e^{i\\pi}+1=0
(search-forward "file:")
(org-element-property :type (org-element-context))))))
+(ert-deftest test-org-element/org-open-at-point ()
+ "Test `org-open-at-point' with link being a heading property."
+ (org-test-with-temp-text
+ "* Headline
+:PROPERTIES:
+:URL: <point>[[info:org#Top]]
+:END:"
+ (org-open-at-point)))
+
;;;; Macro
--
1.8.4
next reply other threads:[~2014-04-11 1:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 1:34 York Zhao [this message]
2014-04-11 7:23 ` Patch for testing `org-open-at-point' Nicolas Goaziou
2014-04-11 10:25 ` Bastien
2014-04-12 14:22 ` York Zhao
2014-04-17 18:48 ` Bastien
2014-04-20 19:19 ` Michael Strey
2014-04-20 19:56 ` York Zhao
2014-06-01 1:12 ` York Zhao
2014-06-01 8:53 ` Bastien
2014-06-01 20:15 ` Achim Gratz
2014-06-01 21:14 ` Bastien
2014-06-01 21:58 ` babel C, C++, D enhancement Thierry Banel
2014-06-06 16:31 ` Eric Schulte
2014-06-07 18:19 ` Thierry Banel
2014-06-08 20:19 ` Thierry Banel
2014-06-08 23:22 ` Eric Schulte
2014-06-09 9:40 ` Thierry Banel
2014-06-13 6:51 ` Achim Gratz
2014-06-13 11:47 ` Eric Schulte
2014-06-13 22:07 ` Thierry Banel
2014-06-16 18:28 ` Achim Gratz
2014-06-16 20:49 ` Thierry Banel
2014-06-16 21:14 ` Thomas S. Dye
2014-06-16 22:24 ` Nick Dokos
2014-06-17 17:16 ` Achim Gratz
2014-06-17 20:51 ` Thierry Banel
2014-06-13 10:55 ` Bastien
2014-06-13 11:58 ` conforming commit messages Was: " Eric Schulte
2014-06-13 14:50 ` Eric Abrahamsen
2014-06-02 19:13 ` Patch for testing `org-open-at-point' Achim Gratz
2014-06-03 7:22 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD3zm219Tu5tQLRB+ubmQ9_DMyScOzp1tXTfv6LauEFHR6YQRQ@mail.gmail.com \
--to=gtdplatform@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).