From: Eric Schulte <schulte.eric@gmail.com>
To: Thierry Banel <tbanelwebmin@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: babel C, C++, D enhancement
Date: Sun, 08 Jun 2014 19:22:30 -0400 [thread overview]
Message-ID: <87tx7vq955.fsf@gmail.com> (raw)
In-Reply-To: <5394C55B.7010906@free.fr> (Thierry Banel's message of "Sun, 08 Jun 2014 22:19:39 +0200")
Thierry Banel <tbanelwebmin@free.fr> writes:
> Hi Eric, hi All
>
> Here is a new patch (do not apply the previous).
> I added a check in the test suite for the D compiler availability
> (and for the C++ compiler as well).
> It silently returns true when the compiler is not found.
>
> To run the test suite I did that:
> - start from an up-to-date org-mode/ GIT directory
> - create a GIT branch, checkout there
> - apply the patch : git am patch-file
> - make clean
> - make autoloads
> - make test-dirty
>
> Eric, this result you were getting is strange:
> FAILED ob-C/inhomogeneous_table
> It is as though the NEW test suite was run against the OLD ob-C.el
> Maybe there was an old .elc compiled file hanging around ?
>
> Anyway, it works fine for me.
> Could someone check and tell me if something goes wrong ?
>
> Have fun
> Thierry
>
Hi Theirry,
This new patch looks great, and the test suite passes locally. I've
just applied it.
Thanks!
Eric
also, thanks for taking the time to flesh out the commit message
>
>
> Le 06/06/2014 18:31, Eric Schulte a écrit :
>> Hi Thierry,
>>
>> This looks wonderful, however after applying this patch I get the
>> following errors when running "make test-dirty".
>>
>>> 10 unexpected results:
>>> FAILED ob-C/inhomogeneous_table
>>> FAILED ob-D/inhomogeneous_table
>>> FAILED ob-D/integer-var
>>> FAILED ob-D/list-list-var
>>> FAILED ob-D/list-var
>>> FAILED ob-D/simple-program
>>> FAILED ob-D/string-var
>>> FAILED ob-D/table
>>> FAILED ob-D/two-integer-var
>>> FAILED ob-D/vector-var
>> Could you update the test suite so that the C tests pass, and the D
>> tests are not executed when D is not available?
>>
>> Also, could you flesh out the commit message so that it meets the Emacs
>> commit message guidelines (http://orgmode.org/worg/org-contribute.html)?
>>
>> Many Thanks,
>> Eric
>>
>>
>
>
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D (see https://u.fsf.org/yw)
next prev parent reply other threads:[~2014-06-08 23:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 1:34 Patch for testing `org-open-at-point' York Zhao
2014-04-11 7:23 ` Nicolas Goaziou
2014-04-11 10:25 ` Bastien
2014-04-12 14:22 ` York Zhao
2014-04-17 18:48 ` Bastien
2014-04-20 19:19 ` Michael Strey
2014-04-20 19:56 ` York Zhao
2014-06-01 1:12 ` York Zhao
2014-06-01 8:53 ` Bastien
2014-06-01 20:15 ` Achim Gratz
2014-06-01 21:14 ` Bastien
2014-06-01 21:58 ` babel C, C++, D enhancement Thierry Banel
2014-06-06 16:31 ` Eric Schulte
2014-06-07 18:19 ` Thierry Banel
2014-06-08 20:19 ` Thierry Banel
2014-06-08 23:22 ` Eric Schulte [this message]
2014-06-09 9:40 ` Thierry Banel
2014-06-13 6:51 ` Achim Gratz
2014-06-13 11:47 ` Eric Schulte
2014-06-13 22:07 ` Thierry Banel
2014-06-16 18:28 ` Achim Gratz
2014-06-16 20:49 ` Thierry Banel
2014-06-16 21:14 ` Thomas S. Dye
2014-06-16 22:24 ` Nick Dokos
2014-06-17 17:16 ` Achim Gratz
2014-06-17 20:51 ` Thierry Banel
2014-06-13 10:55 ` Bastien
2014-06-13 11:58 ` conforming commit messages Was: " Eric Schulte
2014-06-13 14:50 ` Eric Abrahamsen
2014-06-02 19:13 ` Patch for testing `org-open-at-point' Achim Gratz
2014-06-03 7:22 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx7vq955.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=tbanelwebmin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).