emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: Tag set in agenda need a refresh to be used in a filter [7.4]
@ 2011-07-21 17:01 Nicolas Dudebout
  2011-07-28  9:44 ` Bastien
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Dudebout @ 2011-07-21 17:01 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 3129 bytes --]

When filtering with a tag that was just added, the result is not as
expected.

* Steps *
1 - Go in the agenda view.
2 - Attach a tag <T> to an entry <E>.
3 - Filter using tag <T>.
(4 - Refresh the view)

* Expected behavior *
by doing steps 1-3, entry <E> should appear in the filtered output.

* Actual behavior*
step 4 is needed to have entry <E> appear.

* Systems on which tests were performed *
+ emacs 23 with the included version of org-mode and zero configuration
+ emacs 24 with the included version of org-mode and zero configuration
+ emacs 24 with the git version of org-mode and some configuration

I tried to find the problem in org-agenda.el but got a little lost.

Regards,
Nicolas

Emacs  : GNU Emacs 24.0.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.5)
 of 2011-07-21 on cigue, modified by Debian
Package: Org-mode version 7.4

current state:
==============
(setq
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-tab-first-hook '(org-hide-block-toggle-maybe
org-src-native-tab-command-maybe
              org-babel-hide-result-toggle-maybe)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
 org-export-interblocks '((lob org-babel-exp-lob-one-liners) (src
org-babel-exp-inline-src-blocks))
 org-mode-hook '(#[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook org-show-block-all append
local] 5]
         #[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook org-babel-show-result-all
append local] 5]
         org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-babel-pre-tangle-hook '(save-buffer)
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-export-preprocess-before-normalizing-links-hook
'(org-remove-file-link-modifiers)
 org-export-preprocess-before-selecting-backend-code-hook
'(org-beamer-select-beamer-code)
 org-confirm-shell-link-function 'yes-or-no-p
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
org-beamer-auto-fragile-frames
                   org-beamer-place-default-actions-for-lists)
 org-speed-command-hook '(org-speed-command-default-hook
org-babel-speed-command-hook)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
org-babel-execute-safely-maybe)
 org-occur-hook '(org-first-headline-recenter)
 org-export-blocks '((src org-babel-exp-src-blocks nil) (comment
org-export-blocks-format-comment t)
             (ditaa org-export-blocks-format-ditaa nil) (dot
org-export-blocks-format-dot nil))
 org-agenda-files '("~/foo.org")
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
org-cycle-show-empty-lines
          org-optimize-window-after-visibility-change)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 )

[-- Attachment #2: Type: text/html, Size: 3638 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: Tag set in agenda need a refresh to be used in a filter [7.4]
  2011-07-21 17:01 Bug: Tag set in agenda need a refresh to be used in a filter [7.4] Nicolas Dudebout
@ 2011-07-28  9:44 ` Bastien
  2011-07-28 15:19   ` Matt Lundin
  0 siblings, 1 reply; 4+ messages in thread
From: Bastien @ 2011-07-28  9:44 UTC (permalink / raw)
  To: Nicolas Dudebout; +Cc: emacs-orgmode

Hi Nicolas,

Nicolas Dudebout <nicolas.dudebout@gatech.edu> writes:

> When filtering with a tag that was just added, the result is not as
> expected.
>
> * Steps *
> 1 - Go in the agenda view.
> 2 - Attach a tag <T> to an entry <E>.
> 3 - Filter using tag <T>.
> (4 - Refresh the view)
>
> * Expected behavior *
> by doing steps 1-3, entry <E> should appear in the filtered output.
>
> * Actual behavior*
> step 4 is needed to have entry <E> appear.

This is now fixed in git repo, thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: Tag set in agenda need a refresh to be used in a filter [7.4]
  2011-07-28  9:44 ` Bastien
@ 2011-07-28 15:19   ` Matt Lundin
  2011-07-28 15:27     ` Bastien
  0 siblings, 1 reply; 4+ messages in thread
From: Matt Lundin @ 2011-07-28 15:19 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode, Nicolas Dudebout

Hi Bastien,

Bastien <bzg@altern.org> writes:

> Nicolas Dudebout <nicolas.dudebout@gatech.edu> writes:
>
>> When filtering with a tag that was just added, the result is not as
>> expected.
>>
>> * Steps *
>> 1 - Go in the agenda view.
>> 2 - Attach a tag <T> to an entry <E>.
>> 3 - Filter using tag <T>.
>> (4 - Refresh the view)
>>
>> * Expected behavior *
>> by doing steps 1-3, entry <E> should appear in the filtered output.
>>
>> * Actual behavior*
>> step 4 is needed to have entry <E> appear.

I would suggest that this *is* the expected behavior. The cost of
refreshing the agenda is relatively expensive - it should not be done on
each filter. 

If we do want to update the agenda after a tag change, then perhaps we
could update the text properties for the line

> This is now fixed in git repo, thanks!

This has the undesirable consequence of slowing down filtering by
triggering an agenda request.

Best,
Matt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: Tag set in agenda need a refresh to be used in a filter [7.4]
  2011-07-28 15:19   ` Matt Lundin
@ 2011-07-28 15:27     ` Bastien
  0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2011-07-28 15:27 UTC (permalink / raw)
  To: Matt Lundin; +Cc: emacs-orgmode, Nicolas Dudebout

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> I would suggest that this *is* the expected behavior. The cost of
> refreshing the agenda is relatively expensive - it should not be done
> on each filter.

I see.  I have reverted this change.

Still, Nicolas' request makes sense, I would like to find a solution,
but I won't be able to find one before I'm back from holidays.

Thanks,

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-07-28 15:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-21 17:01 Bug: Tag set in agenda need a refresh to be used in a filter [7.4] Nicolas Dudebout
2011-07-28  9:44 ` Bastien
2011-07-28 15:19   ` Matt Lundin
2011-07-28 15:27     ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).