From: Tom Gillespie <tgbugs@gmail.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-tangle.el: restore :tangle closure nil behavior
Date: Tue, 15 Aug 2023 18:41:35 -0700 [thread overview]
Message-ID: <CA+G3_POZkEVxzJ3dTTTe5JzYP+wjTf7p4RxVdZArwaQPROidxQ@mail.gmail.com> (raw)
In-Reply-To: <CA+G3_PO0wVqoKjj4GbQK9=cE0COpAFjS9eDBb1h+Pxd19bdX7A@mail.gmail.com>
After a bit more investigation don't apply this patch because the change
is insufficient to correct another issue.
Specifically org-babel-tangle-collect-blocks must check for and resolve
any closures that are passed to :tangle _before_ testing (string=
src-tfile "no").
As it stands blocks that are marked :tangle (and "no") with a closure
incorrectly make it to a call to (org-babel-get-src-block-info) which causes
a call to org-babel-process-params when :tangle would be "no".
Working on a proper fix now.
next prev parent reply other threads:[~2023-08-16 1:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 20:59 [PATCH] ob-tangle.el: restore :tangle closure nil behavior Tom Gillespie
2023-08-16 1:41 ` Tom Gillespie [this message]
2023-08-16 3:20 ` Tom Gillespie
2023-08-16 9:09 ` Ihor Radchenko
2023-08-16 9:28 ` Tom Gillespie
2023-08-16 9:41 ` Ihor Radchenko
2023-08-16 9:53 ` Tom Gillespie
2023-08-17 10:15 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+G3_POZkEVxzJ3dTTTe5JzYP+wjTf7p4RxVdZArwaQPROidxQ@mail.gmail.com \
--to=tgbugs@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).