From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gCVeM6Up3GQyKwAASxT56A (envelope-from ) for ; Wed, 16 Aug 2023 03:43:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YGVwM6Up3GQdyAAAauVa8A (envelope-from ) for ; Wed, 16 Aug 2023 03:43:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6EEC052494 for ; Wed, 16 Aug 2023 03:43:01 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="Es+Rq0/2"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692150181; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=a9G9YimGx0YzHfafvKZ5JJka6eWhvP5xbn+HnEbH5e8=; b=iZ01Yi13wWL3+nrQyoXwl+Kj/ixXZwb0EkP3uSAjTwxoKxo5jPtpPI7VwXhZSks35QS6h3 i8UnMp18WUXuNkzUeB3XnvgP0H5PtYGl0f+Z4fDa3Y70krtoIPV6DkDHQZGicWnohWAyO1 rZpQQCN2RtKJP7cMJxTFRPjqy5N2o44sD0To73T7I5dZKMQKA7IHF1Sn3IiObDZ00uEjRz clLrzJMOYAybEsWp6FzhP3QVVWT3gOMWkxiZVZF6tkDZCbU5zBwspuRZznLhP/DUTqTSe+ L8iouZU9uYKJRQ47f2ztw9JzSWkXFVL+l+KyhFpOLWdOBtV2VcOZVVAKU1mzzQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="Es+Rq0/2"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692150181; a=rsa-sha256; cv=none; b=uxUGqQgqxslxaEUl5MetqFL9VHUymCAsw3Q20Gv0nKTPL3PL5YfW5KobiMAwGdU/36XOYX fXpD0n7FCBbVYEgQ1ivOIF4nxfSVTXsxxk6RKgowOnETYapPchwHDGH9uAD/n+Oq+Xo7TQ 9riy/YRJuzLCksM4gpyNdW5afqrVTESl/r/zeXvqX/PTc9YDjc9vBB12kuLRljeg2rFtsP fWcB11I7rBPc8y33I6g8FT8BJNtTbbbD1kmu3XWJmMKvHedaW2QRZEVdLWBspw3sRJz4XF pPAtY+78FbApE3rKdFGhstOY+802Qzj7ppJzUe+pbLBORi2Y249YbJBn/BYNZA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW5Y0-0004HC-Cv; Tue, 15 Aug 2023 21:42:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW5Xv-0004Gr-IF for emacs-orgmode@gnu.org; Tue, 15 Aug 2023 21:42:04 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qW5Xn-0000xk-W3 for emacs-orgmode@gnu.org; Tue, 15 Aug 2023 21:42:03 -0400 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-564b6276941so4578485a12.3 for ; Tue, 15 Aug 2023 18:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692150107; x=1692754907; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=a9G9YimGx0YzHfafvKZ5JJka6eWhvP5xbn+HnEbH5e8=; b=Es+Rq0/2wLWAckJXVIlHRiPE7gOUlAKoxS+ro1qQGvzWjhTIEb3x6ZsQZF91gt0ZPh p2oY754aGJK+BqDPXcU2iy2+TBmdpnkF6SRZrkc7zzl2vbJDxG1oyvzI4lhcRCQ40aDi RaRB+3NIMp8pRnkvLqZMCY3GWGtiO1sd0bDQS26T9zVFjcI+VKDWY/8p/Ogrw4Klkx6G dUq+BJPaWFQO2eetWAGVm2AMnBIQuJPMZRnrhlDSLp6UC/mVGdzCkKLEzLThkzMkGbpn uux1a5mGDPccn2905hJpVEY96SKduEHyME1WxKrSFP9UvgiRAIkYr1wqqMP18TFrwT2T hp3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692150107; x=1692754907; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a9G9YimGx0YzHfafvKZ5JJka6eWhvP5xbn+HnEbH5e8=; b=FvHbLMHeL/EALZ3cJiqSXoXv4GdNIClvpk42kc2hLoD7T2cepXgIctYD3MsT4NmIx+ 8n1LAFgiMMkcrNWSKvYEq90GP3Ppudfos6hF6gYttItc55cATkwIWU2+pDPBmJCCgq8/ f4gEtzPJdq4U1MRmHygvY61CRS9VUN0/S/NnXnMLa8SonuAFvKu7XjXWQupafn5vsJOu 83HK/7JbqOML6AxFuzgzWEWidaxK/iJi1VIX2u0ny6lRHzbvOqhYth6n0CJenUqQ40XN kB2DuS3XV2tRMtOiWZE7TAKTTPVvBPNtshrkaWPOKfm1uxmucJMJreuHOy/WIIdGj+ZP G5zA== X-Gm-Message-State: AOJu0Yxm0ejYH1SDozo7+kzvdmstI+u0/6NUtxE88qkdgtT3CIoMaFUo 5a4XaE9bBfcVKulZRN/Onl7SW7aCNyLAGio7YSpzL2LXvyY= X-Google-Smtp-Source: AGHT+IF/Zw9h1cNXOFhRr6GyEJM6Lt0APb32Gl2HPUdA015xwJ5FUrVAR1c5cbcwDrjNunqD7Ej/AHNhw+EeGeTHfKc= X-Received: by 2002:a17:90b:3615:b0:26b:e27:8bc2 with SMTP id ml21-20020a17090b361500b0026b0e278bc2mr287280pjb.45.1692150106518; Tue, 15 Aug 2023 18:41:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tom Gillespie Date: Tue, 15 Aug 2023 18:41:35 -0700 Message-ID: Subject: Re: [PATCH] ob-tangle.el: restore :tangle closure nil behavior To: emacs-orgmode Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=tgbugs@gmail.com; helo=mail-pg1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.04 X-Spam-Score: -8.04 X-Migadu-Queue-Id: 6EEC052494 X-Migadu-Scanner: mx2.migadu.com X-TUID: ksD0SvAKx/Ba After a bit more investigation don't apply this patch because the change is insufficient to correct another issue. Specifically org-babel-tangle-collect-blocks must check for and resolve any closures that are passed to :tangle _before_ testing (string= src-tfile "no"). As it stands blocks that are marked :tangle (and "no") with a closure incorrectly make it to a call to (org-babel-get-src-block-info) which causes a call to org-babel-process-params when :tangle would be "no". Working on a proper fix now.