From: Rainer M Krug <r.m.krug@gmail.com>
To: Charles Berry <ccberry@ucsd.edu>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [babel][PATCHES] ob-R patches for review
Date: Thu, 8 May 2014 12:02:36 +0200 [thread overview]
Message-ID: <C5F03688-8A03-449D-85FC-A89B57555E42@gmail.com> (raw)
In-Reply-To: <loom.20140508T041255-834@post.gmane.org>
Envoyé de mon iPhone
> Le 8 mai 2014 à 04:26, Charles Berry <ccberry@ucsd.edu> a écrit :
>
> Eric Schulte <schulte.eric <at> gmail.com> writes:
>
>>
>> Rainer M Krug <Rainer <at> krugs.de> writes:
>>
>>> Hi
>>>
>>> Attached please find seven patches for review to implement the storing
>>> of org variables in their own environment and to make the org-issued R
>>> code look nicer in the R session.
>>>
>>> Thanks,
>>>
>>> Rainer
>>
>> Hi Rainer,
>>
>> Thanks for these patches. I don't have the R experience to review or
>> maintain them, but I'm happy to apply them.
>>
>> I missed some previous discussion in this thread. Are these patches
>> ready to be applied as is?
>
>
> IMO, the patches hard coded behaviors that would better be customizable
> and optional.
I'll give feedback tomorrow and let you know about customization of the name of the environment. The general behavior of storing the variables in an environment should not be customizable as it is
1) safer then the behavior of storing each variable separately
2) no changes for the user are introduced
Cheers
Rainer
>
> Rainer and I had some back and forth about this -- see the thread.
>
> Best,
>
> Chuck
>
>
>
next prev parent reply other threads:[~2014-05-08 10:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 12:43 [babel][PATCHES] ob-R patches for review Rainer M Krug
2014-04-29 18:15 ` Charles Berry
2014-04-30 12:28 ` Rainer M Krug
2014-04-30 22:49 ` Charles C. Berry
2014-05-01 9:10 ` Rainer M Krug
2014-05-07 10:27 ` Eric Schulte
2014-05-08 2:26 ` Charles Berry
2014-05-08 10:02 ` Rainer M Krug [this message]
2014-05-09 9:11 ` Rainer M Krug
2014-05-09 12:02 ` Rainer M Krug
2014-05-08 9:57 ` Rainer M Krug
2014-05-09 13:03 ` Bastien
2014-05-09 13:45 ` Rainer M Krug
2014-05-09 14:34 ` Eric Schulte
2014-05-12 8:33 ` Rainer M Krug
2014-05-12 12:23 ` Suvayu Ali
2014-05-12 12:41 ` Rainer M Krug
2014-05-12 14:01 ` Queestion concerning lists - was: " Rainer M Krug
2014-05-12 15:23 ` Eric Schulte
2014-05-12 15:21 ` Eric Schulte
2014-05-12 19:08 ` Rainer M Krug
2014-05-12 22:05 ` Charles C. Berry
[not found] ` <m2y4y2f499.fsf@krugs.de>
2014-05-16 18:22 ` Charles C. Berry
2014-06-06 16:11 ` Eric Schulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5F03688-8A03-449D-85FC-A89B57555E42@gmail.com \
--to=r.m.krug@gmail.com \
--cc=ccberry@ucsd.edu \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).