* Bug: The org-entry-put add extra space after each invoking [7.5 (release_7.5.260.geb2a)]
@ 2011-05-08 15:02 wujun zhou
2011-05-24 19:02 ` David Maus
0 siblings, 1 reply; 2+ messages in thread
From: wujun zhou @ 2011-05-08 15:02 UTC (permalink / raw)
To: emacs-orgmode
Each time I invoke the org-entry-put, I will get an extra space before
the value, like this:
<----before
:prop: 1
<----after (org-entry-put pom prop 2)
:prop: 2
<----and after invoking servel times:
:prop: 3
----------------
It's harmless to org-property API, but somewhat annoying.
I think, this is introduced by commit
92b603c8920623d9c581e2c58809ad2c73fcd475.
It changed the regex from
(concat "^[ \t]*:" property ":\\(.*\\)") (cdr range) t)
to
(concat "^[ \t]*:" (regexp-quote property) ":[ \t]*\\(\\S-.*\\)"))
Thus, the following
(goto-char (match-beginning 1))
will be after instead of before the spaces.
And the
(and value (insert " " value))
will add the extra space.
Emacs : GNU Emacs 23.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.4)
of 2011-05-04 on zwj-ubuntu
Package: Org-mode version 7.5 (release_7.5.260.geb2a)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: The org-entry-put add extra space after each invoking [7.5 (release_7.5.260.geb2a)]
2011-05-08 15:02 Bug: The org-entry-put add extra space after each invoking [7.5 (release_7.5.260.geb2a)] wujun zhou
@ 2011-05-24 19:02 ` David Maus
0 siblings, 0 replies; 2+ messages in thread
From: David Maus @ 2011-05-24 19:02 UTC (permalink / raw)
To: wujun zhou; +Cc: emacs-orgmode
At Sun, 8 May 2011 23:02:30 +0800,
wujun zhou wrote:
>
> Each time I invoke the org-entry-put, I will get an extra space before
> the value, like this:
> <----before
> :prop: 1
> <----after (org-entry-put pom prop 2)
> :prop: 2
> <----and after invoking servel times:
> :prop: 3
> ----------------
> It's harmless to org-property API, but somewhat annoying.
>
> I think, this is introduced by commit
> 92b603c8920623d9c581e2c58809ad2c73fcd475.
>
> It changed the regex from
>
> (concat "^[ \t]*:" property ":\\(.*\\)") (cdr range) t)
>
> to
>
> (concat "^[ \t]*:" (regexp-quote property) ":[ \t]*\\(\\S-.*\\)"))
>
> Thus, the following
> (goto-char (match-beginning 1))
> will be after instead of before the spaces.
>
> And the
> (and value (insert " " value))
> will add the extra space.
Thanks for the analysis, I just pushed a fix for this problem to
master.
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-24 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-08 15:02 Bug: The org-entry-put add extra space after each invoking [7.5 (release_7.5.260.geb2a)] wujun zhou
2011-05-24 19:02 ` David Maus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).