Bug: Incorrect duration format example in comments in 'org-duration.el' [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)]

Bug: Incorrect duration format example in comments in 'org-duration.el' [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)]

[Johnson]

I'm contributing to an org file python parser to correctly parse durations.

I found the comments in org-duration.el 
(https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-duration.el#L31 
<https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-duration.el#L31>), 
mentioning that `1d3h5min` is a valid duration format.

So, I expect the following should work:

M-x eval-expression <RET>
(org-duration-string-to-minutes "1d3h5min") <RET>

However, the following error occurred:

(error "Invalid duration format: \"1d3h5min\"")

I also tried adding "1d3h5min" as an EFFORT property, however, resulting 
in the same error. I assume that the comment should be fixed by removing 
this particular example? (Other examples work fine)

-- 
Sincerely,
Johnson

Re: Bug: Incorrect duration format example in comments in 'org-duration.el' [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)]

[Nicolas Goaziou]

Hello,

Johnson <j3soon@gapp.nthu.edu.tw> writes:

> I'm contributing to an org file python parser to correctly parse durations.
>
> I found the comments in org-duration.el
> (https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-duration.el#L31 
> <https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-duration.el#L31>),
> mentioning that `1d3h5min` is a valid duration format.
>
> So, I expect the following should work:
>
> M-x eval-expression <RET>
> (org-duration-string-to-minutes "1d3h5min") <RET>

I cannot reproduce it. I get 1625.0.

Maybe your Org is too old. So-called "compact" form was introduced after the others.

Regards,
-- 
Nicolas Goaziou

Re: Bug: Incorrect duration format example in comments in 'org-duration.el' [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)]

[Johnson]

Yes, the issue is due to using an older version of Org.

I searched the change log and saw that the compact form is introduced in 
Org 9.4, while mine is 9.3.

Thanks for your help!

Sincerely,
Johnson

On 4/20/2021 9:42 PM, NicolasGoaziou wrote:
> Hello,
>
> Johnson <j3soon@gapp.nthu.edu.tw> writes:
>
>> I'm contributing to an org file python parser to correctly parse durations.
>>
>> I found the comments in org-duration.el
>> (https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-duration.el#L31
>> <https://code.orgmode.org/bzg/org-mode/src/master/lisp/org-duration.el#L31>),
>> mentioning that `1d3h5min` is a valid duration format.
>>
>> So, I expect the following should work:
>>
>> M-x eval-expression <RET>
>> (org-duration-string-to-minutes "1d3h5min") <RET>
> I cannot reproduce it. I get 1625.0.
>
> Maybe your Org is too old. So-called "compact" form was introduced after the others.
>
> Regards,