emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Max Nikulin <manikulin@gmail.com>
To: "Rudolf Adamkovič" <salutis@me.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code
Date: Tue, 7 Feb 2023 22:13:19 +0700	[thread overview]
Message-ID: <8f58aaaf-638b-1338-f58a-41048fea8f6d@gmail.com> (raw)
In-Reply-To: <87357hfyyl.fsf@localhost>

On 07/02/2023 19:21, Ihor Radchenko wrote:
> Max Nikulin writes:
>>
>> Historically subr-x was avoided in Org. Latest discussion:
>> https://list.orgmode.org/b1eef17f-b8ef-2e2a-d463-7909b03ce6eb@gmail.com/T/#u
> 
> ... which concluded that it is safe to use subr-x.
> If we need to add a require, so be it. I see no major downsides.

I do not mind.

Since content of subr-x.el consists of `defsubst' definitions, likely it 
is preferable to use

     (eval-when-compile (require 'subr-x))



  reply	other threads:[~2023-02-07 15:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 21:42 [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code Rudolf Adamkovič
2023-02-07  2:24 ` Max Nikulin
2023-02-07  8:39   ` Rudolf Adamkovič
2023-02-07 12:13     ` Max Nikulin
2023-02-07 12:21       ` Ihor Radchenko
2023-02-07 15:13         ` Max Nikulin [this message]
2023-02-15 18:22           ` Rudolf Adamkovič
2023-02-17 10:41             ` Ihor Radchenko
2023-02-17 12:51               ` Ihor Radchenko
2023-03-24 16:37                 ` Ihor Radchenko
2023-04-01 21:22                   ` Rudolf Adamkovič

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f58aaaf-638b-1338-f58a-41048fea8f6d@gmail.com \
    --to=manikulin@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).