From: Max Nikulin <manikulin@gmail.com>
To: "Rudolf Adamkovič" <salutis@me.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code
Date: Tue, 7 Feb 2023 19:13:37 +0700 [thread overview]
Message-ID: <2cae1646-a4ee-f856-d27e-0ee924aad4bc@gmail.com> (raw)
In-Reply-To: <m2sffhna2x.fsf@me.com>
Rudolf, I am afraid there is another obstacle till your step to improve
Org may be completed.
On 07/02/2023 15:39, Rudolf Adamkovič wrote:
> - (let* ((input-file
> - (make-temp-file "test" nil ".info"))
> - (input-content
> - (concat (format "@setfilename %s" input-file) "\n"
> - "@node Top" "\n"
> - (format "@displaymath{%s}" math-example) "\n")))
> + (let* ((input-file (make-temp-file "test" nil ".info"))
> + (input-content (string-join
In emacs-26 `string-join' is defined in subr-x.el, but ox-texinfo.el
does not have (require 'subr-x). Personally I see nothing bad in
(format "@displaymath\n%s\n@end" math-example)
Historically subr-x was avoided in Org. Latest discussion:
https://list.orgmode.org/b1eef17f-b8ef-2e2a-d463-7909b03ce6eb@gmail.com/T/#u
[BUG] Re: 98e168b48 Add compatibility wrapper for
string-clean-whitespace (Emacs 26 compatibility) Fri, 07 Oct 2022
13:14:11 +0800
I will leave the decision to the maintainers since I have no particular
opinion. Alternatively you may use (mapconcat #'identity (list) "\n").
It is preferable to fix earlier added call to `string-join' in this
file. The similar approach should be applied to the tests added by this
patch.
> + (list (format "@setfilename %s" input-file)
> + "@node Top"
> + "@displaymath"
next prev parent reply other threads:[~2023-02-07 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 21:42 [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code Rudolf Adamkovič
2023-02-07 2:24 ` Max Nikulin
2023-02-07 8:39 ` Rudolf Adamkovič
2023-02-07 12:13 ` Max Nikulin [this message]
2023-02-07 12:21 ` Ihor Radchenko
2023-02-07 15:13 ` Max Nikulin
2023-02-15 18:22 ` Rudolf Adamkovič
2023-02-17 10:41 ` Ihor Radchenko
2023-02-17 12:51 ` Ihor Radchenko
2023-03-24 16:37 ` Ihor Radchenko
2023-04-01 21:22 ` Rudolf Adamkovič
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cae1646-a4ee-f856-d27e-0ee924aad4bc@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=salutis@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).