From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EH0NM5JA4mNtIQEAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 13:14:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wDUiM5JA4mMbKwAA9RJhRA (envelope-from ) for ; Tue, 07 Feb 2023 13:14:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A36993023C for ; Tue, 7 Feb 2023 13:14:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPMr9-00050Z-UA; Tue, 07 Feb 2023 07:13:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPMr4-0004xh-HD for emacs-orgmode@gnu.org; Tue, 07 Feb 2023 07:13:46 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPMr1-00054V-GF for emacs-orgmode@gnu.org; Tue, 07 Feb 2023 07:13:46 -0500 Received: by mail-pl1-x62e.google.com with SMTP id h15so8052481plk.12 for ; Tue, 07 Feb 2023 04:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=XHSe+/6KI55lqBWS4MrZqT82Jay6h/3TeDC49rqwQdE=; b=l3pyNMSBVB79KurjREtzgiflPIElPuy6Sdgm3nDxJfqrs6h9NeQzVgAXtDg7Bmvr9J YBLSDtArNu1EuGruN6I/Nbuqs9ATIX+Wwno5nB/m4mJvgOhg/KiaPmlpJ39sFK5Q2sgH 4NI2k/TMNquSiEz4G7zTa3Chn/VDSTbFNRjjNcegwe0eNdMtC8e8+ck8FfRfWNtuzaaQ M2iepTllwDFcZI3gWEfJS0w6CYVNH0PQpJeB1s4ZG11l0BS+qSo0gBCiO6UOGWvivkYL kE2tlc4Ex4ENxFtmxc2KkMVHaOUxIqua5fvloP2+WXti5xvGdymEdU43iIFa0f50/QkO lMng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XHSe+/6KI55lqBWS4MrZqT82Jay6h/3TeDC49rqwQdE=; b=Rt/hkD694dZFhAZRmMBZEdrXnK4K2e5RqtdtOZS5SGKw1ufbE//Jv6nV5vgoiP8QgH qlBCgXrndi2Xy5vq2KxCJAyj+1cbo+wCrLlEYL8iJkEIAEwTStpS0t+FS24y6sn2YteK nfuMF2aQ+Kuj+/ivoT9ndpwlaSZ9EEcuXM7BCL+hHDxwqLqJ3jCggmw0bzykV4S/vwLI sPo9t0LxOLLPv4ZdKRznKe5M1virZudd0VpuRyl1hyhDtRxi1MmTSeFKEuoNbLcxg/9H r6bQPH64mTCu7215guRB57ZBj6SznzI3aQA1JblsthBmk1YycxwfP4btWHwZCi7T2DS2 E6Ew== X-Gm-Message-State: AO0yUKUpKnwCcZ33h/HgBfoi/Ojgp11QopOYe3340DdudUNL1adzmpcO 6nOZ2h3y/kvtY10CWH3lqho= X-Google-Smtp-Source: AK7set+iVUuSqNu6PCNTVMrH9+nkzmi26nCUu+AaEyyOv2QRJH/SEsR3xFflEWn/gWS97FmaTazU4w== X-Received: by 2002:a05:6a21:3391:b0:b8:42b0:1215 with SMTP id yy17-20020a056a21339100b000b842b01215mr4196118pzb.5.1675772021261; Tue, 07 Feb 2023 04:13:41 -0800 (PST) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id p23-20020aa78617000000b0058d92d6e4ddsm1693192pfn.5.2023.02.07.04.13.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 04:13:40 -0800 (PST) Message-ID: <2cae1646-a4ee-f856-d27e-0ee924aad4bc@gmail.com> Date: Tue, 7 Feb 2023 19:13:37 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code Content-Language: en-US To: =?UTF-8?Q?Rudolf_Adamkovi=c4=8d?= , emacs-orgmode@gnu.org References: <20230206214216.64841-1-salutis@me.com> From: Max Nikulin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=manikulin@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=l3pyNMSB; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675772050; a=rsa-sha256; cv=none; b=OGwCO2hn+corleZEJqrORp3JPJfgLk/J9JViaCmgdoQSm4RnY6unqB5dnO/aJfIDt9xDBR fZ8xfHKw2L81miAVjEpotpJcBqyeFFpZLOBjJtKSYYbeNnltLbxASQDWrCEGTHauwDA1fH eLfU5q/YAOra2CtLlFLkJ1+I0T6eYsurIHsxtUV4C+3BDaSvdj1UX/uQvDHuEN27ov7Q2V QEUhdCqLUoaRE18rfnY7YxzO0UR4u1DUsee4hMHQKDXyi+5vC1Sl7Ioq61+oxNQ6qNaadg lJL52ER1u13V6XWqEpSYlv97bEnbMNPhlK0UAdp3OPkUZR89DCpRhHaBC5BaVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675772050; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=XHSe+/6KI55lqBWS4MrZqT82Jay6h/3TeDC49rqwQdE=; b=LRHP+mI8+Xavg7QcX1JoBq89QXWCGEibIQHo+xerUa617amLjAJDMAadgrwW4Gc2tc0Jsj 5Agw53inWwAG5jsOCnrLJL0dQvlfrg92A5s0c+cVFu5UGS4NPkKossENx3H5Q1SY5DV3Sx QjJWxzeb+ueQZRXNILvKaI23tGU9v8c9CS+ROhwSyiiLZsOg0kXADSbx8fe7AtSMSEJ9nL mUzyjGAmWo09WwGMgubq4nscvkXoX9bQMj6LLfjEo/9IH0k1WKsq33cQCJfl5Ye7vjREQy TSunurqOA7UQK03EMuJVbB3O9UOImac8uWRrUfhsdKyzV40Q37LPGDExF3WhdA== X-Migadu-Spam-Score: -1.79 X-Spam-Score: -1.79 X-Migadu-Queue-Id: A36993023C X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=l3pyNMSB; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: UJyRkXJ5S4aZ Rudolf, I am afraid there is another obstacle till your step to improve Org may be completed. On 07/02/2023 15:39, Rudolf Adamkovič wrote: > - (let* ((input-file > - (make-temp-file "test" nil ".info")) > - (input-content > - (concat (format "@setfilename %s" input-file) "\n" > - "@node Top" "\n" > - (format "@displaymath{%s}" math-example) "\n"))) > + (let* ((input-file (make-temp-file "test" nil ".info")) > + (input-content (string-join In emacs-26 `string-join' is defined in subr-x.el, but ox-texinfo.el does not have (require 'subr-x). Personally I see nothing bad in (format "@displaymath\n%s\n@end" math-example) Historically subr-x was avoided in Org. Latest discussion: https://list.orgmode.org/b1eef17f-b8ef-2e2a-d463-7909b03ce6eb@gmail.com/T/#u [BUG] Re: 98e168b48 Add compatibility wrapper for string-clean-whitespace (Emacs 26 compatibility) Fri, 07 Oct 2022 13:14:11 +0800 I will leave the decision to the maintainers since I have no particular opinion. Alternatively you may use (mapconcat #'identity (list) "\n"). It is preferable to fix earlier added call to `string-join' in this file. The similar approach should be applied to the tests added by this patch. > + (list (format "@setfilename %s" input-file) > + "@node Top" > + "@displaymath"