From: Carsten Dominik <carsten.dominik@gmail.com>
To: "Gregory J. Grubbs" <gregory@dynapse.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Quote path argument in ob-ditaa
Date: Sun, 18 Jul 2010 07:51:10 +0200 [thread overview]
Message-ID: <8E58882A-8AFD-44F8-909B-DDA7B7B14A8B@gmail.com> (raw)
In-Reply-To: <878w59a163.fsf@dynapse.com>
Applied, thanks
- Carsten
On Jul 18, 2010, at 6:01 AM, Gregory J. Grubbs wrote:
> Patch fixes ob-ditaa for paths that contain spaces and other
> shell-interpreted characters.
>
>
> diff --git a/lisp/ob-ditaa.el b/lisp/ob-ditaa.el
> index 1f56d12..cc06246 100644
> --- a/lisp/ob-ditaa.el
> +++ b/lisp/ob-ditaa.el
> @@ -59,7 +59,7 @@ called by `org-babel-execute-src-block'."
> (error "Could not find ditaa.jar at %s" org-ditaa-jar-path))
> (with-temp-file in-file (insert body))
> (message (concat "java -jar " org-ditaa-jar-path " " cmdline " "
> in-file " " out-file))
> - (shell-command (concat "java -jar " org-ditaa-jar-path " "
> cmdline " " in-file " " out-file))
> + (shell-command (concat "java -jar " (shell-quote-argument org-
> ditaa-jar-path) " " cmdline " " in-file " " out-file))
> out-file))
>
> (defun org-babel-prep-session:ditaa (session params)
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
next prev parent reply other threads:[~2010-07-18 5:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-17 20:57 imenu support for babel blocks David O'Toole
2010-07-18 4:01 ` [PATCH] Quote path argument in ob-ditaa Gregory J. Grubbs
2010-07-18 5:43 ` Patchwork: Patch 150 Accepted Carsten Dominik
2010-07-18 5:51 ` Carsten Dominik [this message]
2010-07-20 22:30 ` imenu support for babel blocks Eric Schulte
2010-12-01 16:17 ` Sébastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8E58882A-8AFD-44F8-909B-DDA7B7B14A8B@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=gregory@dynapse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).