From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Quote path argument in ob-ditaa Date: Sun, 18 Jul 2010 07:51:10 +0200 Message-ID: <8E58882A-8AFD-44F8-909B-DDA7B7B14A8B@gmail.com> References: <878w59a163.fsf@dynapse.com> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=49463 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OaMmQ-0007LI-2x for emacs-orgmode@gnu.org; Sun, 18 Jul 2010 01:51:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OaMmO-0000Q9-RX for emacs-orgmode@gnu.org; Sun, 18 Jul 2010 01:51:13 -0400 Received: from mail-ew0-f41.google.com ([209.85.215.41]:55284) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OaMmO-0000PD-JV for emacs-orgmode@gnu.org; Sun, 18 Jul 2010 01:51:12 -0400 Received: by mail-ew0-f41.google.com with SMTP id 28so1216333ewy.0 for ; Sat, 17 Jul 2010 22:51:12 -0700 (PDT) In-Reply-To: <878w59a163.fsf@dynapse.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Gregory J. Grubbs" Cc: emacs-orgmode@gnu.org Applied, thanks - Carsten On Jul 18, 2010, at 6:01 AM, Gregory J. Grubbs wrote: > Patch fixes ob-ditaa for paths that contain spaces and other > shell-interpreted characters. > > > diff --git a/lisp/ob-ditaa.el b/lisp/ob-ditaa.el > index 1f56d12..cc06246 100644 > --- a/lisp/ob-ditaa.el > +++ b/lisp/ob-ditaa.el > @@ -59,7 +59,7 @@ called by `org-babel-execute-src-block'." > (error "Could not find ditaa.jar at %s" org-ditaa-jar-path)) > (with-temp-file in-file (insert body)) > (message (concat "java -jar " org-ditaa-jar-path " " cmdline " " > in-file " " out-file)) > - (shell-command (concat "java -jar " org-ditaa-jar-path " " > cmdline " " in-file " " out-file)) > + (shell-command (concat "java -jar " (shell-quote-argument org- > ditaa-jar-path) " " cmdline " " in-file " " out-file)) > out-file)) > > (defun org-babel-prep-session:ditaa (session params) > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten