modeline vs modeline

modeline vs modeline

[Brendan Halpin]

I've just updated to emacs-snapshot 24.2.50.1 (of 2012-10-18) on Debian,
and have run in to a faces problem. In short references to modeline
should be to mode-line. Making 4 changes in org-faces.el is enough.

Brendan
-- 
Brendan Halpin,   Department of Sociology,   University of Limerick,   Ireland
Tel: w +353-61-213147  f +353-61-202569  h +353-61-338562;  Room F1-009 x 3147
mailto:brendan.halpin@ul.ie    ULSociology on Facebook: http://on.fb.me/fjIK9t
http://teaching.sociology.ul.ie/bhalpin/wordpress         twitter:@ULSociology

Re: modeline vs modeline

[Sebastien Vauban]

Hi Brendan,

Brendan Halpin wrote:
> I've just updated to emacs-snapshot 24.2.50.1 (of 2012-10-18) on Debian,
> and have run in to a faces problem. In short references to modeline
> should be to mode-line. Making 4 changes in org-faces.el is enough.

Maybe you could provide a patch?

Though, a quick note: AFAICT, in GNU Emacs, the modeline is written
"mode-line"; but written "modeline" under XEmacs. I don't know how that fact
is supported in Org (as it is still supposed to run under XEmacs as well).

Best regards,
  Seb

-- 
Sebastien Vauban

Re: modeline vs modeline

[Brendan Halpin]

On Wed, Oct 24 2012, Sebastien Vauban wrote:

> Maybe you could provide a patch?
>
> Though, a quick note: AFAICT, in GNU Emacs, the modeline is written
> "mode-line"; but written "modeline" under XEmacs. I don't know how that fact
> is supported in Org (as it is still supposed to run under XEmacs as well).

You could express the patch like this:

(progn 
  (find-file "org-mode/lisp/org-faces.el")
  (goto-char (point-min))
  (replace-string "modeline" "mode-line")
  (save-buffer))

or more conventionally:


695c695
<   (org-compatible-face 'modeline
---
>   (org-compatible-face 'mode-line
701c701
<   (org-compatible-face 'modeline
---
>   (org-compatible-face 'mode-line
773c773
< (org-copy-face 'modeline 'org-mode-line-clock
---
> (org-copy-face 'mode-line 'org-mode-line-clock
775c775
< (org-copy-face 'modeline 'org-mode-line-clock-overrun
---
> (org-copy-face 'mode-line 'org-mode-line-clock-overrun



but that still leaves the problem of dealing with the Emacs/Xemacs
compatibility. Is there a way of aliasing face attributes?

Brendan
-- 
Brendan Halpin,   Department of Sociology,   University of Limerick,   Ireland
Tel: w +353-61-213147  f +353-61-202569  h +353-61-338562;  Room F1-009 x 3147
mailto:brendan.halpin@ul.ie    ULSociology on Facebook: http://on.fb.me/fjIK9t
http://teaching.sociology.ul.ie/bhalpin/wordpress         twitter:@ULSociology

Re: modeline vs modeline

[Bastien]

Hi Brendan,

Brendan Halpin <brendan.halpin@ul.ie> writes:

> I've just updated to emacs-snapshot 24.2.50.1 (of 2012-10-18) on Debian,
> and have run in to a faces problem. In short references to modeline
> should be to mode-line. Making 4 changes in org-faces.el is enough.

Fixed, thanks.

-- 
 Bastien

Re: modeline vs modeline

[Bastien]

Hi Brendan,

Brendan Halpin <brendan.halpin@ul.ie> writes:

> but that still leaves the problem of dealing with the Emacs/Xemacs
> compatibility. Is there a way of aliasing face attributes?

Aliasing the face name should be enough.  But the 'modeline face 
has been removed from Emacs at the beginning of this month, so I'm 
not in favor of recreating an alias in Org's core.  If the alias
is needed by XEmacs people, it should be made in XEmacs, as this
is not an Org-only compatibility issue.

Best,

-- 
 Bastien