* modeline vs modeline
@ 2012-10-23 20:44 Brendan Halpin
2012-10-24 8:48 ` Sebastien Vauban
2012-10-24 9:22 ` Bastien
0 siblings, 2 replies; 5+ messages in thread
From: Brendan Halpin @ 2012-10-23 20:44 UTC (permalink / raw)
To: orgmode
I've just updated to emacs-snapshot 24.2.50.1 (of 2012-10-18) on Debian,
and have run in to a faces problem. In short references to modeline
should be to mode-line. Making 4 changes in org-faces.el is enough.
Brendan
--
Brendan Halpin, Department of Sociology, University of Limerick, Ireland
Tel: w +353-61-213147 f +353-61-202569 h +353-61-338562; Room F1-009 x 3147
mailto:brendan.halpin@ul.ie ULSociology on Facebook: http://on.fb.me/fjIK9t
http://teaching.sociology.ul.ie/bhalpin/wordpress twitter:@ULSociology
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: modeline vs modeline
2012-10-23 20:44 modeline vs modeline Brendan Halpin
@ 2012-10-24 8:48 ` Sebastien Vauban
2012-10-24 9:10 ` Brendan Halpin
2012-10-24 9:22 ` Bastien
1 sibling, 1 reply; 5+ messages in thread
From: Sebastien Vauban @ 2012-10-24 8:48 UTC (permalink / raw)
To: emacs-orgmode-mXXj517/zsQ
Hi Brendan,
Brendan Halpin wrote:
> I've just updated to emacs-snapshot 24.2.50.1 (of 2012-10-18) on Debian,
> and have run in to a faces problem. In short references to modeline
> should be to mode-line. Making 4 changes in org-faces.el is enough.
Maybe you could provide a patch?
Though, a quick note: AFAICT, in GNU Emacs, the modeline is written
"mode-line"; but written "modeline" under XEmacs. I don't know how that fact
is supported in Org (as it is still supposed to run under XEmacs as well).
Best regards,
Seb
--
Sebastien Vauban
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: modeline vs modeline
2012-10-24 8:48 ` Sebastien Vauban
@ 2012-10-24 9:10 ` Brendan Halpin
2012-10-24 13:27 ` Bastien
0 siblings, 1 reply; 5+ messages in thread
From: Brendan Halpin @ 2012-10-24 9:10 UTC (permalink / raw)
To: emacs-orgmode
On Wed, Oct 24 2012, Sebastien Vauban wrote:
> Maybe you could provide a patch?
>
> Though, a quick note: AFAICT, in GNU Emacs, the modeline is written
> "mode-line"; but written "modeline" under XEmacs. I don't know how that fact
> is supported in Org (as it is still supposed to run under XEmacs as well).
You could express the patch like this:
(progn
(find-file "org-mode/lisp/org-faces.el")
(goto-char (point-min))
(replace-string "modeline" "mode-line")
(save-buffer))
or more conventionally:
695c695
< (org-compatible-face 'modeline
---
> (org-compatible-face 'mode-line
701c701
< (org-compatible-face 'modeline
---
> (org-compatible-face 'mode-line
773c773
< (org-copy-face 'modeline 'org-mode-line-clock
---
> (org-copy-face 'mode-line 'org-mode-line-clock
775c775
< (org-copy-face 'modeline 'org-mode-line-clock-overrun
---
> (org-copy-face 'mode-line 'org-mode-line-clock-overrun
but that still leaves the problem of dealing with the Emacs/Xemacs
compatibility. Is there a way of aliasing face attributes?
Brendan
--
Brendan Halpin, Department of Sociology, University of Limerick, Ireland
Tel: w +353-61-213147 f +353-61-202569 h +353-61-338562; Room F1-009 x 3147
mailto:brendan.halpin@ul.ie ULSociology on Facebook: http://on.fb.me/fjIK9t
http://teaching.sociology.ul.ie/bhalpin/wordpress twitter:@ULSociology
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: modeline vs modeline
2012-10-23 20:44 modeline vs modeline Brendan Halpin
2012-10-24 8:48 ` Sebastien Vauban
@ 2012-10-24 9:22 ` Bastien
1 sibling, 0 replies; 5+ messages in thread
From: Bastien @ 2012-10-24 9:22 UTC (permalink / raw)
To: brendan.halpin; +Cc: orgmode
Hi Brendan,
Brendan Halpin <brendan.halpin@ul.ie> writes:
> I've just updated to emacs-snapshot 24.2.50.1 (of 2012-10-18) on Debian,
> and have run in to a faces problem. In short references to modeline
> should be to mode-line. Making 4 changes in org-faces.el is enough.
Fixed, thanks.
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: modeline vs modeline
2012-10-24 9:10 ` Brendan Halpin
@ 2012-10-24 13:27 ` Bastien
0 siblings, 0 replies; 5+ messages in thread
From: Bastien @ 2012-10-24 13:27 UTC (permalink / raw)
To: brendan.halpin; +Cc: emacs-orgmode
Hi Brendan,
Brendan Halpin <brendan.halpin@ul.ie> writes:
> but that still leaves the problem of dealing with the Emacs/Xemacs
> compatibility. Is there a way of aliasing face attributes?
Aliasing the face name should be enough. But the 'modeline face
has been removed from Emacs at the beginning of this month, so I'm
not in favor of recreating an alias in Org's core. If the alias
is needed by XEmacs people, it should be made in XEmacs, as this
is not an Org-only compatibility issue.
Best,
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-24 13:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-23 20:44 modeline vs modeline Brendan Halpin
2012-10-24 8:48 ` Sebastien Vauban
2012-10-24 9:10 ` Brendan Halpin
2012-10-24 13:27 ` Bastien
2012-10-24 9:22 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).