emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] ox-latex: Don't quote const in defcustom.
@ 2013-10-29 16:20 Rüdiger Sonderfeld
  2013-10-29 19:34 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Rüdiger Sonderfeld @ 2013-10-29 16:20 UTC (permalink / raw)
  To: emacs-orgmode

Quoting it would set `org-export-latex' not to `minted' but `(quote
minted)' and thus breaking the export.

* lisp/ox-latex.el (org-latex-listings): Don't quote const value.

Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
---
 lisp/ox-latex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
index 2af5de6..87c503c 100644
--- a/lisp/ox-latex.el
+++ b/lisp/ox-latex.el
@@ -655,7 +655,7 @@ (defcustom org-latex-listings nil
   :group 'org-export-latex
   :type '(choice
 	  (const :tag "Use listings" t)
-	  (const :tag "Use minted" 'minted)
+	  (const :tag "Use minted" minted)
 	  (const :tag "Export verbatim" nil)))
 
 (defcustom org-latex-listings-langs
-- 
1.8.4.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ox-latex: Don't quote const in defcustom.
  2013-10-29 16:20 [PATCH] ox-latex: Don't quote const in defcustom Rüdiger Sonderfeld
@ 2013-10-29 19:34 ` Nicolas Goaziou
  2013-10-29 19:35   ` Rüdiger Sonderfeld
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2013-10-29 19:34 UTC (permalink / raw)
  To: Rüdiger Sonderfeld; +Cc: emacs-orgmode

Hello,

Rüdiger Sonderfeld <ruediger@c-plusplus.de> writes:

> Quoting it would set `org-export-latex' not to `minted' but `(quote
> minted)' and thus breaking the export.
>
> * lisp/ox-latex.el (org-latex-listings): Don't quote const value.
>
> Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
> ---
>  lisp/ox-latex.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index 2af5de6..87c503c 100644
> --- a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -655,7 +655,7 @@ (defcustom org-latex-listings nil
>    :group 'org-export-latex
>    :type '(choice
>  	  (const :tag "Use listings" t)
> -	  (const :tag "Use minted" 'minted)
> +	  (const :tag "Use minted" minted)
>  	  (const :tag "Export verbatim" nil)))

Good catch. Thank you.

Have you signed FSF papers? If you haven't, you need to add TINYCHANGE
at the end of the commit message so I can apply the patch.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ox-latex: Don't quote const in defcustom.
  2013-10-29 19:34 ` Nicolas Goaziou
@ 2013-10-29 19:35   ` Rüdiger Sonderfeld
  2013-10-29 19:50     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Rüdiger Sonderfeld @ 2013-10-29 19:35 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

On Tuesday 29 October 2013 20:34:04 Nicolas Goaziou wrote:
> Have you signed FSF papers?

Yes.

Regards,
Rüdiger

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ox-latex: Don't quote const in defcustom.
  2013-10-29 19:35   ` Rüdiger Sonderfeld
@ 2013-10-29 19:50     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2013-10-29 19:50 UTC (permalink / raw)
  To: Rüdiger Sonderfeld; +Cc: emacs-orgmode

Rüdiger Sonderfeld <ruediger@c-plusplus.de> writes:

> On Tuesday 29 October 2013 20:34:04 Nicolas Goaziou wrote:
>> Have you signed FSF papers?
>
> Yes.

OK. I applied your patch and updated information on Worg.

Thank you again.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-10-29 19:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29 16:20 [PATCH] ox-latex: Don't quote const in defcustom Rüdiger Sonderfeld
2013-10-29 19:34 ` Nicolas Goaziou
2013-10-29 19:35   ` Rüdiger Sonderfeld
2013-10-29 19:50     ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).