From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "Rüdiger Sonderfeld" <ruediger@c-plusplus.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-latex: Don't quote const in defcustom.
Date: Tue, 29 Oct 2013 20:34:04 +0100 [thread overview]
Message-ID: <87zjprc1n7.fsf@gmail.com> (raw)
In-Reply-To: <4155801.pG1hJsBqrn@descartes> ("Rüdiger Sonderfeld"'s message of "Tue, 29 Oct 2013 17:20:20 +0100")
Hello,
Rüdiger Sonderfeld <ruediger@c-plusplus.de> writes:
> Quoting it would set `org-export-latex' not to `minted' but `(quote
> minted)' and thus breaking the export.
>
> * lisp/ox-latex.el (org-latex-listings): Don't quote const value.
>
> Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
> ---
> lisp/ox-latex.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index 2af5de6..87c503c 100644
> --- a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -655,7 +655,7 @@ (defcustom org-latex-listings nil
> :group 'org-export-latex
> :type '(choice
> (const :tag "Use listings" t)
> - (const :tag "Use minted" 'minted)
> + (const :tag "Use minted" minted)
> (const :tag "Export verbatim" nil)))
Good catch. Thank you.
Have you signed FSF papers? If you haven't, you need to add TINYCHANGE
at the end of the commit message so I can apply the patch.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2013-10-29 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 16:20 [PATCH] ox-latex: Don't quote const in defcustom Rüdiger Sonderfeld
2013-10-29 19:34 ` Nicolas Goaziou [this message]
2013-10-29 19:35 ` Rüdiger Sonderfeld
2013-10-29 19:50 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjprc1n7.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ruediger@c-plusplus.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).