Bug: Can't access org agenda custom command [9.2.1 (9.2.1-33-g029cf6-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20190225/)]

Bug: Can't access org agenda custom command [9.2.1 (9.2.1-33-g029cf6-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20190225/)]

[Gustavo Barros]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See

https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Hi all,

I've been having trouble with my custom agenda commands since the latest
update.

The agenda dispatcher used to work fine until the last update, but now,
given one of my custom agenda commands, it issues the error
"org-agenda-get-restriction-and-command: Wrong number of arguments".

I do believe the problem is due to the recent changes to the mentioned
function, discussed in the following thread:
http://lists.gnu.org/archive/html/emacs-orgmode/2019-02/msg00291.html

To test things, I started with `emacs -Q`, and evaluated the following:


#+begin_src emacs-lisp
(require 'package)
(package-initialize)

(require 'org)

(custom-set-variables
'(org-agenda-files
(quote
("~/Gustavo/Documents/Pessoal/Org Agenda/pessoal.org" 
"~/Gustavo/Documents/Pessoal/Org Agenda/trabalho.org")))
'(org-agenda-custom-commands
(quote
(("h" . "Home Agenda Views")
("hh" "Home Agenda"
((agenda ""
((org-agenda-overriding-header "Today (Home)")
(org-agenda-span
(quote day))))
(todo ""
((org-agenda-overriding-header "Tasks")
(org-agenda-todo-ignore-with-date t)
(org-agenda-skip-function
(quote
(org-agenda-skip-entry-if
(quote todo)
(quote
("SOMEDAY"))))))))
((org-agenda-files
(quote
("~/Gustavo/Documents/Pessoal/Org Agenda/pessoal.org"))))
nil)
("hs" "Someday Tasks" todo "SOMEDAY"
((org-agenda-files
(quote
("~/Gustavo/Documents/Pessoal/Org Agenda/pessoal.org")))))
("w" . "Work Agenda Views")
("ww" "Work Agenda"
((agenda ""
((org-agenda-overriding-header "Today (Work)")
(org-agenda-span
(quote day))))
(todo ""
((org-agenda-overriding-header "Tasks")
(org-agenda-todo-ignore-with-date t)
(org-agenda-skip-function
(quote
(org-agenda-skip-entry-if
(quote todo)
(quote
("SOMEDAY"))))))))
nil nil)
("ws" "Someday Tasks" todo "SOMEDAY" nil)
("n" "Agenda and all TODOs"
((agenda "" nil)
(alltodo "" nil))
nil)))))

#+end_src

With this, =M-x org-version= returns: "Org mode version 9.2.1
(9.2.1-33-g029cf6-elpaplus @
/home/gustavo/.emacs.d/elpa/org-plus-contrib-20190225/)".

In this setting, if I try to access my "Work Agenda", with =M-x
org-agenda w w= I get the mentioned error
"org-agenda-get-restriction-and-command: Wrong number of arguments"

If I then evaluate the previous value of
=org-agenda-get-restriction-and-command= , as contained in
=org-plus-contrib-20190218= proper behaviour is restored.

Best regards,
Gustavo Barros.



Emacs : GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
of 2019-01-02
Package: Org mode version 9.2.1 (9.2.1-33-g029cf6-elpaplus @ 
/home/gustavo/.emacs.d/elpa/org-plus-contrib-20190225/)

current state:
==============
(setq
org-src-mode-hook '(org-src-babel-configure-edit-buffer
org-src-mode-configure-edit-buffer)
org-metadown-hook '(org-babel-pop-to-session-maybe)
org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
org-agenda-files '("~/Gustavo/Documents/Pessoal/Org Agenda/pessoal.org"
"~/Gustavo/Documents/Pessoal/Org Agenda/trabalho.org")
org-mode-hook '(#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-show-all append local]
5]
#[0 "\300\301\302\303\304$\207"
[add-hook change-major-mode-hook org-babel-show-result-all
append local]
5]
org-babel-result-hide-spec org-babel-hide-all-hashes
org-eldoc-load)
org-archive-hook '(org-attach-archive-delete-maybe)
org-confirm-elisp-link-function 'yes-or-no-p
org-agenda-before-write-hook '(org-agenda-add-entry-text)
org-metaup-hook '(org-babel-load-in-session-maybe)
org-bibtex-headline-format-function #[257 "\300.\236A\207" [:title] 3 
"\n\n(fn ENTRY)"]
org-babel-pre-tangle-hook '(save-buffer)
org-tab-first-hook '(org-babel-hide-result-toggle-maybe
org-babel-header-arg-expand)
org-src-lang-modes '(("arduino" . arduino) ("redis" . redis) ("php" . php)
("C" . c) ("C++" . c++) ("asymptote" . asy)
("bash" . sh) ("beamer" . latex) ("calc" . fundamental)
("cpp" . c++) ("ditaa" . artist) ("dot" . fundamental)
("elisp" . emacs-lisp) ("ocaml" . tuareg)
("screen" . shell-script) ("shell" . sh)
("sqlite" . sql))
org-occur-hook '(org-first-headline-recenter)
org-cycle-hook '(org-cycle-hide-archived-subtrees 
org-cycle-show-empty-lines
org-optimize-window-after-visibility-change)
org-speed-command-hook '(org-speed-command-activate
org-babel-speed-command-activate)
org-confirm-shell-link-function 'yes-or-no-p
org-link-parameters '(("id" :follow org-id-open)
("eww" :follow eww :store org-eww-store-link)
("rmail" :follow org-rmail-open :store
org-rmail-store-link)
("mhe" :follow org-mhe-open :store org-mhe-store-link)
("irc" :follow org-irc-visit :store org-irc-store-link
:export org-irc-export)
("info" :follow org-info-open :export org-info-export
:store org-info-store-link)
("gnus" :follow org-gnus-open :store
org-gnus-store-link)
("docview" :follow org-docview-open :export
org-docview-export :store org-docview-store-link)
("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store
org-bbdb-store-link)
("w3m" :store org-w3m-store-link) ("file+sys")
("file+emacs")
("elfeed" :follow elfeed-link-open :store
elfeed-link-store-link)
("doi" :follow org--open-doi-link)
("elisp" :follow org--open-elisp-link)
("file" :complete org-file-complete-link)
("ftp" :follow
(lambda (path) (browse-url (concat "ftp:" path))))
("help" :follow org--open-help-link)
("http" :follow
(lambda (path) (browse-url (concat "http:" path))))
("https" :follow
(lambda (path) (browse-url (concat "https:" path))))
("mailto" :follow
(lambda (path) (browse-url (concat "mailto:" path))))
("news" :follow
(lambda (path) (browse-url (concat "news:" path))))
("shell" :follow org--open-shell-link))
org-agenda-custom-commands '(("h" . "Home Agenda Views")
("hh" "Home Agenda"
((agenda ""
((org-agenda-overriding-header "Today (Home)")
(org-agenda-span (quote day)))
)
(todo ""
((org-agenda-overriding-header "Tasks")
(org-agenda-todo-ignore-with-date t)
(org-agenda-skip-function
(quote
(org-agenda-skip-entry-if (quote todo)
(quote ("SOMEDAY")))
)
)
)
)
)
((org-agenda-files
(quote
("~/Gustavo/Documents/Pessoal/Org Agenda/pessoal.org")
)
)
)
nil)
("hs" "Someday Tasks" todo "SOMEDAY"
((org-agenda-files
(quote
("~/Gustavo/Documents/Pessoal/Org Agenda/pessoal.org")
)
)
)
)
("w" . "Work Agenda Views")
("ww" "Work Agenda"
((agenda ""
((org-agenda-overriding-header "Today (Work)")
(org-agenda-span (quote day)))
)
(todo ""
((org-agenda-overriding-header "Tasks")
(org-agenda-todo-ignore-with-date t)
(org-agenda-skip-function
(quote
(org-agenda-skip-entry-if (quote todo)
(quote ("SOMEDAY")))
)
)
)
)
)
nil nil)
("ws" "Someday Tasks" todo "SOMEDAY" nil)
("n" "Agenda and all TODOs"
((agenda "" nil) (alltodo "" nil)) nil)
)
)

Re: Bug: Can't access org agenda custom command [9.2.1 (9.2.1-33-g029cf6-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20190225/)]

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On 2019-02-26 02:19, Gustavo Barros <gusbrs.2016@gmail.com> 
writes:

> I've been having trouble with my custom agenda commands since 
> the latest
> update.
>
> The agenda dispatcher used to work fine until the last update, 
> but now,
> given one of my custom agenda commands, it issues the error
> "org-agenda-get-restriction-and-command: Wrong number of 
> arguments".

I think the problem is on line 3036 of org-agenda.el. The code

				(propertize match nil 'face 'org-warning))

should be
				(propertize match 'face 'org-warning))

(I changed it locally and it now works)

Best,

Alan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Bug: Can't access org agenda custom command [9.2.1 (9.2.1-33-g029cf6-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20190225/)]

[Nicolas Goaziou]

Hello,

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

> On 2019-02-26 02:19, Gustavo Barros <gusbrs.2016@gmail.com> writes:
>
>> I've been having trouble with my custom agenda commands since the
>> latest
>> update.
>>
>> The agenda dispatcher used to work fine until the last update, but
>> now,
>> given one of my custom agenda commands, it issues the error
>> "org-agenda-get-restriction-and-command: Wrong number of arguments".
>
> I think the problem is on line 3036 of org-agenda.el. The code
>
> 				(propertize match nil 'face 'org-warning))
>
> should be
> 				(propertize match 'face 'org-warning))
>
> (I changed it locally and it now works)

This was fixed yesterday.

Regards,

-- 
Nicolas Goaziou

Re: Bug: Can't access org agenda custom command [9.2.1 (9.2.1-33-g029cf6-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20190225/)]

[Alan Schmitt]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

On 2019-02-26 09:14, Nicolas Goaziou <mail@nicolasgoaziou.fr> 
writes:

>> I think the problem is on line 3036 of org-agenda.el. The code
>>
>> 				(propertize match nil 'face 'org-warning))
>>
>> should be
>> 				(propertize match 'face 'org-warning))
>>
>> (I changed it locally and it now works)
>
> This was fixed yesterday.

Thank you. I did not know that as I updated org-plus-contrib this
morning and had the bug.

Best,

Alan


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]