Help me contribute to org

Help me contribute to org

[emacs]

[-- Attachment #1.1: Type: text/plain, Size: 230 bytes --]

To whom it may concern,

I would like to contribute to org-mode but I have no experience with git. I would like to start with something small - adding translations for my language.

Could somebody please guide?

Kind regards

[-- Attachment #1.2: Type: text/html, Size: 454 bytes --]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

Re: Help me contribute to org

[Ihor Radchenko]

emacs@supporter.mailer.me writes:

> I would like to contribute to org-mode but I have no experience with git. I would like to start with something small - adding translations for my language.
>
> Could somebody please guide?

The easiest way would be:

1. Download Org mode source code from command line:

   git clone https://git.savannah.gnu.org/cgit/emacs/org-mode.git

   This will create "org-mode" folder in the place you run the above
   command.

2. Open one of the Org files in the downloaded folder.
   For example org-mode/lisp/ox.el has `org-export-dictionary' variable
   - you can search for the variable in the file simply using isearch:
     C-s org-export-dictionary

3. Edit the file as needed, adding translations. You simply can follow
   by example when adding new translations.

4. M-x vc-diff <RET>
   This will open a buffer with you edits converted into "diff".

5. C-x C-w in the diff buffer and save it to a file like
   "my-edits.diff".

6. Drop an email to this mailing list, explaining what you did and
   attaching the "diff" file.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Help me contribute to org

[emacs]

[-- Attachment #1: Type: text/plain, Size: 1813 bytes --]

Hello everyone and thank you yantar for the response,

I did just that:
I have added a Polish translation for everything that I could find and corrected one existing one.

I have also attached the diff file to this message.

Is that alright?

------- Original Message -------
On Friday, September 8th, 2023 at 07:53, Ihor Radchenko 'yantar92 at posteo.net' <emacs@supporter.mailer.me> wrote:
> emacs@supporter.mailer.me writes:
> 

> > I would like to contribute to org-mode but I have no experience with git. I would like to start with something small - adding translations for my language.
> > 

> > Could somebody please guide?
> 

> 

> The easiest way would be:
> 

> 1. Download Org mode source code from command line:
> 

> git clone https://git.savannah.gnu.org/cgit/emacs/org-mode.git
> 

> This will create "org-mode" folder in the place you run the above
> command.
> 

> 2. Open one of the Org files in the downloaded folder.
> For example org-mode/lisp/ox.el has `org-export-dictionary' variable
> - you can search for the variable in the file simply using isearch:
> C-s org-export-dictionary
> 

> 3. Edit the file as needed, adding translations. You simply can follow
> by example when adding new translations.
> 

> 4. M-x vc-diff <RET>
> 

> This will open a buffer with you edits converted into "diff".
> 

> 5. C-x C-w in the diff buffer and save it to a file like
> "my-edits.diff".
> 

> 6. Drop an email to this mailing list, explaining what you did and
> attaching the "diff" file.
> 

> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at https://orgmode.org/.
> 

> Support Org development at https://liberapay.com/org-mode,
> 

> or support my work at https://liberapay.com/yantar92

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: _Edits.diff --]
[-- Type: text/x-patch; name=_Edits.diff, Size: 7079 bytes --]

diff --git a/lisp/ox.el b/lisp/ox.el
index f8ccd2a9f..38643c077 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6215,7 +6215,7 @@ them."
      ("ja" :default "次ページに続く")
      ("nl" :default "Vervolg op volgende pagina")
      ("nn" :default "Held fram på neste side")
-     ("pl" :default "Kontynuacja na następnej stronie")
+     ("pl" :default "Ciąg dalszy na następnej stronie")
      ("pt" :default "Continua na página seguinte")
      ("pt_BR" :html "Continua na pr&oacute;xima p&aacute;gina" :ascii "Continua na proxima pagina" :default "Continua na próxima página")
      ("ro" :default "Continuare pe pagina următoare")
@@ -6229,6 +6229,7 @@ them."
      ("fa" :default "ساخته شده")
      ("nl" :default "Gemaakt op")  ;; must be followed by a date or date+time
      ("nn" :default "Oppretta")
+     ("pl" :default "Wygenerowano o") ; must be followed by a date or date+time
      ("pt_BR" :default "Criado em")
      ("ro" :default "Creat")
      ("sl" :default "Ustvarjeno")
@@ -6278,6 +6279,7 @@ them."
      ("no" :default "Ligning")
      ("nb" :default "Ligning")
      ("nn" :default "Likning")
+     ("pl" :default "Równanie" :ascii "Rownanie")
      ("pt_BR" :html "Equa&ccedil;&atilde;o" :default "Equação" :ascii "Equacao")
      ("ro" :default "Ecuația")
      ("ru" :html "&#1059;&#1088;&#1072;&#1074;&#1085;&#1077;&#1085;&#1080;&#1077;"
@@ -6301,6 +6303,7 @@ them."
      ("no" :default "Illustrasjon")
      ("nb" :default "Illustrasjon")
      ("nn" :default "Illustrasjon")
+     ("pl" :default "Obrazek") ; alternativly "Rysunek"
      ("pt_BR" :default "Figura")
      ("ro" :default "Imaginea")
      ("ru" :html "&#1056;&#1080;&#1089;&#1091;&#1085;&#1086;&#1082;" :utf-8 "Рисунок")
@@ -6323,6 +6326,7 @@ them."
      ("no" :default "Illustrasjon %d")
      ("nb" :default "Illustrasjon %d")
      ("nn" :default "Illustrasjon %d")
+     ("pl" :default "Obrazek %d") ; alternativly "Rysunek %d"
      ("pt_BR" :default "Figura %d:")
      ("ro" :default "Imaginea %d:")
      ("ru" :html "&#1056;&#1080;&#1089;. %d.:" :utf-8 "Рис. %d.:")
@@ -6375,6 +6379,7 @@ them."
      ("nn" :default "Programliste")
      ("no" :default "Dataprogrammer")
      ("nb" :default "Dataprogrammer")
+     ("pl" :default "Indeks") ; probably too vague but better than nothing
      ("pt_BR" :html "&Iacute;ndice de Listagens" :default "Índice de Listagens" :ascii "Indice de Listagens")
      ("ru" :html "&#1057;&#1087;&#1080;&#1089;&#1086;&#1082; &#1088;&#1072;&#1089;&#1087;&#1077;&#1095;&#1072;&#1090;&#1086;&#1082;"
       :utf-8 "Список распечаток")
@@ -6398,6 +6403,7 @@ them."
      ("no" :default "Tabeller")
      ("nb" :default "Tabeller")
      ("nn" :default "Tabeller")
+     ("pl" :default "Indeks tabel")
      ("pt_BR" :html "&Iacute;ndice de Tabelas" :default "Índice de Tabelas" :ascii "Indice de Tabelas")
      ("ro" :default "Tabele")
      ("ru" :html "&#1057;&#1087;&#1080;&#1089;&#1086;&#1082; &#1090;&#1072;&#1073;&#1083;&#1080;&#1094;"
@@ -6421,6 +6427,7 @@ them."
      ("nn" :default "Program")
      ("no" :default "Dataprogram")
      ("nb" :default "Dataprogram")
+     ("pl" :default "Indeks")
      ("pt_BR" :default "Listagem")
      ("ro" :default "Lista")
      ("ru" :html "&#1056;&#1072;&#1089;&#1087;&#1077;&#1095;&#1072;&#1090;&#1082;&#1072;"
@@ -6445,6 +6452,7 @@ them."
      ("no" :default "Dataprogram %d")
      ("nb" :default "Dataprogram %d")
      ("ro" :default "Lista %d")
+     ("pl" :default "Indeks %d:")
      ("pt_BR" :default "Listagem %d:")
      ("ru" :html "&#1056;&#1072;&#1089;&#1087;&#1077;&#1095;&#1072;&#1090;&#1082;&#1072; %d.:"
       :utf-8 "Распечатка %d.:")
@@ -6462,6 +6470,7 @@ them."
      ("it" :default "Riferimenti")
      ("nl" :default "Bronverwijzingen")
      ("nn" :default "Kjelder")
+     ("pl" :default "Odwołania") ; could be "Referencje" but I think its too englishy
      ("pt_BR" :html "Refer&ecirc;ncias" :default "Referências" :ascii "Referencias")
      ("ro" :default "Bibliografie")
      ("sl" :default "Reference")
@@ -6476,6 +6485,7 @@ them."
      ("nl" :default "Zie figuur %s"
       :html "Zie figuur&nbsp;%s" :latex "Zie figuur~%s")
      ("nn" :default "Sjå figur %s")
+     ("pl" :default "Patrz obrazek %s") ; alternativly "Patrz rysunek %s"
      ("pt_BR" :default "Veja a figura %s")
      ("ro" :default "Vezi figura %s")
      ("sl" :default "Glej sliko %s")
@@ -6489,6 +6499,7 @@ them."
      ("nl" :default "Zie programma %s"
       :html "Zie programma&nbsp;%s" :latex "Zie programma~%s")
      ("nn" :default "Sjå program %s")
+     ("pl" :default "Patrz indeks %s")
      ("pt_BR" :default "Veja a listagem %s")
      ("ro" :default "Vezi tabelul %s")
      ("sl" :default "Glej izpis programa %s")
@@ -6508,6 +6519,7 @@ them."
      ("nl" :default "Zie sectie %s"
       :html "Zie sectie&nbsp;%s" :latex "Zie sectie~%s")
      ("nn" :default "Sjå del %s")
+     ("pl" :default "Patrz sekcja %s") ; seems rough
      ("pt_BR" :html "Veja a se&ccedil;&atilde;o %s" :default "Veja a seção %s"
       :ascii "Veja a secao %s")
      ("ro" :default "Vezi secțiunea %s")
@@ -6526,6 +6538,7 @@ them."
      ("nl" :default "Zie tabel %s"
       :html "Zie tabel&nbsp;%s" :latex "Zie tabel~%s")
      ("nn" :default "Sjå tabell %s")
+     ("pl" :default "Patrz tabela %s")
      ("pt_BR" :default "Veja a tabela %s")
      ("ro" :default "Vezi tabelul %s")
      ("sl" :default "Glej tabelo %s")
@@ -6544,6 +6557,7 @@ them."
      ("ja" :default "表" :html "&#34920;")
      ("nl" :default "Tabel")
      ("nn" :default "Tabell")
+     ("pl" :default "Tabela")
      ("pt_BR" :default "Tabela")
      ("ro" :default "Tabel")
      ("ru" :html "&#1058;&#1072;&#1073;&#1083;&#1080;&#1094;&#1072;"
@@ -6567,6 +6581,7 @@ them."
      ("no" :default "Tabell %d")
      ("nb" :default "Tabell %d")
      ("nn" :default "Tabell %d")
+     ("pl" :default "Tabela %d"
      ("pt_BR" :default "Tabela %d:")
      ("ro" :default "Tabel %d")
      ("ru" :html "&#1058;&#1072;&#1073;&#1083;&#1080;&#1094;&#1072; %d.:"
@@ -6595,7 +6610,7 @@ them."
      ("no" :default "Innhold")
      ("nb" :default "Innhold")
      ("nn" :default "Innhald")
-     ("pl" :html "Spis tre&#x015b;ci")
+     ("pl" :default "Spis treści" :html "Spis tre&#x015b;ci")
      ("pt_BR" :html "&Iacute;ndice" :utf-8 "Índice" :ascii "Indice")
      ("ro" :default "Cuprins")
      ("ru" :html "&#1057;&#1086;&#1076;&#1077;&#1088;&#1078;&#1072;&#1085;&#1080;&#1077;"
@@ -6618,6 +6633,7 @@ them."
      ("ja" :default "不明な参照先")
      ("nl" :default "Onbekende verwijzing")
      ("nn" :default "Ukjend kjelde")
+     ("pl" :default "Nieznane odwołanie") ; alternatively "Nieokreślone odwołanie"
      ("pt_BR" :html "Refer&ecirc;ncia desconhecida" :default "Referência desconhecida" :ascii "Referencia desconhecida")
      ("ro" :default "Referință necunoscută")
      ("ru" :html "&#1053;&#1077;&#1080;&#1079;&#1074;&#1077;&#1089;&#1090;&#1085;&#1072;&#1103; &#1089;&#1089;&#1099;&#1083;&#1082;&#1072;"

[-- Attachment #3: signature.asc --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

Re: Help me contribute to org

[Ihor Radchenko]

emacs@supporter.mailer.me writes:

> Hello everyone and thank you yantar for the response,
>
> I did just that:
> I have added a Polish translation for everything that I could find and corrected one existing one.
>
> I have also attached the diff file to this message.
>
> Is that alright?

Yup. Thanks!
I created a patch on your behalf using the attached diff file.
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7de89d0a4

You can see your changes applied by following the above link or when you
update to the latest main (using "git pull" or by running "git clone
..." fresh)

Other variable that can benefit from more translations is
`org-clock-clocktable-language-setup'

In addition, see
https://list.orgmode.org/orgmode/87y1rat98w.fsf@localhost/ where I
listed some ways to contribute to Org that do not involve programming.

Finally, our generic contribution guide is in
https://orgmode.org/worg/org-contribute.html#org4d31cca

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Help me contribute to org

[Ihor Radchenko]

[ I am adding Org mailing list back to CC. Please use "Reply All" or
  "Wide reply" in your MUA to keep the conversation public ]

emacs@supporter.mailer.me writes:

> Hi,
> thank you for merging the changes for me.
>
> I have looked into the org-clock-clocktable-language-setup variable and I am not sure what do two of the columns mean: "L" (second after the language) and "ALL" (I do not know the context so I am not sure about how to translate it.
> Do you know where can I find more info on it?

I just added a short comment explaining what they mean:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9eaca51c5

"L" sands for "Level"
and "ALL" is used when clock table is built from multiple files.
"ALL" is placed in place of heading names to mark a line summarizing
clock data for all the files.

> Also after I run make test I get this summary
> Ran 1169 tests, 1156 results as expected, 1 unexpected, 12 skipped (2023-09-14 13:27:11+0200, 26.109088 sec)
> 2 expected failures
>
> 1 unexpected results:
>
>    FAILED  test-org-clok/org-clock-update-time-maybe  ... (equal "CLOCK: [2023-04-29 Sat 00:00]--[2023-05-04 Thu 01:00] => 121:00" #("CLOCK: [2023-04-29 sob 00:00]--[2023-05-04 czw 01:00] => 121:00"

Thanks for letting me know! Should be fixed now on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1d35ebd93

Some tests incorrectly assume English is the default system language and
assert English weekday names.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Help me contribute to org

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:

>> I have looked into the org-clock-clocktable-language-setup variable and I am not sure what do two of the columns mean: "L" (second after the language) and "ALL" (I do not know the context so I am not sure about how to translate it.
>> Do you know where can I find more info on it?
>
> I just added a short comment explaining what they mean:
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9eaca51c5
>
> "L" sands for "Level"
> and "ALL" is used when clock table is built from multiple files.
> "ALL" is placed in place of heading names to mark a line summarizing
> clock data for all the files.

One month have passed since the last activity in this thread.
If you encountered any difficulties, feel free to ask any question.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Help me contribute to org

[Ihor Radchenko]

emacs@supporter.mailer.me writes:

> I have gone through a half of the githowto and have watched the magit video in full.
> I will explain what I am doing step by step, so that you can comment on each of them;
>
> 1. git clone git://git.savannah.gnu.org/emacs/org-mode.git/
> 2. git config user.name + user.email
> 3. edit org-clock.el file
> 4. stage change (in magit)
> 5. commit change (with tinychange)
>
> What now?
> Should I do something witch branches and patches? ("Details on how to submit patches")?

Now, you can create a patch from Magit status buffer:
patch (W) -> create (c) -> create (c) -> <RET>
This will create a patch file in org-mode folder.

You can then attach the patch file when sending email to this mailing
list.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: Help me contribute to org

[Ihor Radchenko]

emacs@supporter.mailer.me writes:

>> I am wondering if "Rubryka" might be better compared to "Nagłówek".
> ...
> "Rubryka" is rarely used so I would stray from it.
> "Nagłówek" is something that is oftern bigger in scope, so it can be not perfect.
> I would consider
> - "Etykieta" - similar to english Label
> - "Nazwa" - english Name
> - "Zdarzenie (happening?) and "Wydarzenie" (event) might also be good since we are talking about time.
>
> If you feel like we're better of this way,You might
> swap it to "Etykieta" for now and add a comment so that
> other Poles can help with that, since I am not sure.

Not sure if I like the alternatives.
Given that we already use "Headline", which also has a more "global"
sense compared to "heading", let it be "Nagłówek".

Applied, onto main, changing the commit message to imperative and adding
changelog entry to conform to our commit message conventions in
https://orgmode.org/worg/org-contribute.html#commit-messages

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0b0bf03e4

Thanks for your contribution!

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>