emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Phil Jackson <phil@shellarchive.co.uk>
Cc: Tokuya Kameshima <kames@fa2.so-net.ne.jp>, emacs-orgmode@gnu.org
Subject: Re: org-bookmark.el
Date: Thu, 28 Feb 2008 19:54:25 +0000	[thread overview]
Message-ID: <87y794n9fy.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87ejaxhxwl.fsf@shellarchive.co.uk> (Phil Jackson's message of "Thu, 28 Feb 2008 16:02:34 +0000")

Phil Jackson <phil@shellarchive.co.uk> writes:

> Bastien <bzg@altern.org> writes:
>
>> In any case, this should be implemented in org.el directly.  When
>> `org-store-link' checks whether we are in dired-mode or in a buffer
>> visiting a file, then it would also check whether 'org-bookmark is
>> provided (with (featurep 'org-bookmark)...) and act accordingly if it
>> is.
>
> I don't think it needs to go into org.el does it? When org-bookmark gets
> it's turn upon `org-store-link' it should check a variable called, for
> example, `org-bookmark-check-bookmarks-first' and then if that's non-nil
> check major-mode and act accordingly. This will keep `org-store-link'
> nice and clean.

Of course, you're right.

But I doubt whether `org-bookmark-check-bookmarks-first' would be useful
here.  People using `org-bookmark.el' are likely to use it in dired-mode
and in buffer visiting files as well.  Actually, I would use it just for
that (not really for creating links from the bookmarks list.)

`org-bookmark-store-link' could just check if we are in a dired buffer,
in a buffer visiting a file, or in a bookmark list, and act accordingly.

When in dired or visiting a file, it would try to fetch a bookmark.  
If there are more than one, then it will prompt the user for the 
bookmark to use.

Tokuya, what do you think?  
Do you want to implement this?

-- 
Bastien

  reply	other threads:[~2008-02-28 19:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-27 15:39 org-bookmark.el Tokuya Kameshima
2008-02-27 16:06 ` org-bookmark.el Carsten Dominik
2008-02-27 16:21 ` org-bookmark.el Bastien Guerry
2008-02-28 14:20   ` org-bookmark.el Tokuya Kameshima
2008-02-28 15:04     ` org-bookmark.el Bastien
2008-02-28 16:02       ` org-bookmark.el Phil Jackson
2008-02-28 19:54         ` Bastien [this message]
2008-02-28 20:53           ` org-bookmark.el Phil Jackson
2008-02-29  1:14             ` org-bookmark.el Bastien Guerry
2008-02-29 14:25               ` org-bookmark.el Tokuya Kameshima
2008-02-29 18:47                 ` org-bookmark.el Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y794n9fy.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kames@fa2.so-net.ne.jp \
    --cc=phil@shellarchive.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).