From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: org-bookmark.el
Date: Thu, 28 Feb 2008 19:54:25 +0000
Message-ID: <87y794n9fy.fsf@bzg.ath.cx>
References: <uzltmpfw6.wl%kames@fa2.so-net.ne.jp> <87ir0ajrol.fsf@bzg.ath.cx>
	<utzjttb5g.wl%kames@fa2.so-net.ne.jp> <87fxvdi0kq.fsf@bzg.ath.cx>
	<87ejaxhxwl.fsf@shellarchive.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JUopw-00069U-Tj
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 14:54:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JUops-00069C-CM
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 14:54:36 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JUops-000698-8g
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 14:54:32 -0500
Received: from ug-out-1314.google.com ([66.249.92.173])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <bastienguerry@googlemail.com>) id 1JUopr-0004TK-Vw
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2008 14:54:32 -0500
Received: by ug-out-1314.google.com with SMTP id a2so492721ugf.48
	for <emacs-orgmode@gnu.org>; Thu, 28 Feb 2008 11:54:30 -0800 (PST)
In-Reply-To: <87ejaxhxwl.fsf@shellarchive.co.uk> (Phil Jackson's message of
	"Thu, 28 Feb 2008 16:02:34 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Phil Jackson <phil@shellarchive.co.uk>
Cc: Tokuya Kameshima <kames@fa2.so-net.ne.jp>, emacs-orgmode@gnu.org

Phil Jackson <phil@shellarchive.co.uk> writes:

> Bastien <bzg@altern.org> writes:
>
>> In any case, this should be implemented in org.el directly.  When
>> `org-store-link' checks whether we are in dired-mode or in a buffer
>> visiting a file, then it would also check whether 'org-bookmark is
>> provided (with (featurep 'org-bookmark)...) and act accordingly if it
>> is.
>
> I don't think it needs to go into org.el does it? When org-bookmark gets
> it's turn upon `org-store-link' it should check a variable called, for
> example, `org-bookmark-check-bookmarks-first' and then if that's non-nil
> check major-mode and act accordingly. This will keep `org-store-link'
> nice and clean.

Of course, you're right.

But I doubt whether `org-bookmark-check-bookmarks-first' would be useful
here.  People using `org-bookmark.el' are likely to use it in dired-mode
and in buffer visiting files as well.  Actually, I would use it just for
that (not really for creating links from the bookmarks list.)

`org-bookmark-store-link' could just check if we are in a dired buffer,
in a buffer visiting a file, or in a bookmark list, and act accordingly.

When in dired or visiting a file, it would try to fetch a bookmark.  
If there are more than one, then it will prompt the user for the 
bookmark to use.

Tokuya, what do you think?  
Do you want to implement this?

-- 
Bastien