From: Bastien <bzg@gnu.org>
To: Dieter Schoen <dieter@schoen.or.at>
Cc: emacs-orgmode@gnu.org, Eric Schulte <schulte.eric@gmail.com>
Subject: Re: ob-lua.el
Date: Sat, 24 May 2014 14:25:05 +0200 [thread overview]
Message-ID: <87y4xrxt26.fsf@bzg.ath.cx> (raw)
In-Reply-To: <871tvjzbrb.wl%dieter@schoen.or.at> (Dieter Schoen's message of "Sat, 24 May 2014 12:55:52 +0200")
Hi Dieter,
Dieter Schoen <dieter@schoen.or.at> writes:
> I have my name to the copyright, but left in the name of the authors
> of ob-python.el, as I used that as a template.
> Is that ok?
Yes -- but I don't see your name anywhere in the file.
> Another change to the first version is that it's now also possible
> to do :results value and :results value pp.
> (The first version still had python wrapper code in there.)
Great!
> The Lua pretty-printer function is a home-brew, as Lua does not provide
> much in that direction out of the box, at least to my knowledge.
What ob-lua.el depends on?
You declare functions that suggests there is both lua-mode.el and
lua.el* -- I think this is a leftover from ob-pyhton.el. Can you
double-check this? Also, there should be a note explaining how to
install lua-mode.el, since it is not part of Emacs.
* See (defcustom org-babel-lua-mode ...
Also, there is (defvar org-src-preserve-indentation) which is not
used.
Let's do some more cleaning and then apply this to master.
Thanks!
--
Bastien
next prev parent reply other threads:[~2014-05-24 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 20:26 ob-lua.el dieter
2014-05-12 15:26 ` ob-lua.el Eric Schulte
2014-05-13 10:57 ` ob-lua.el Dieter Schoen
2014-05-21 7:30 ` ob-lua.el Bastien
2014-05-24 10:55 ` ob-lua.el Dieter Schoen
2014-05-24 12:25 ` Bastien [this message]
2014-05-24 21:17 ` ob-lua.el Dieter Schoen
2014-05-25 5:24 ` ob-lua.el Bastien
2014-05-26 20:57 ` ob-lua.el Dieter Schoen
2014-05-29 17:57 ` ob-lua.el Bastien
-- strict thread matches above, loose matches on Subject: below --
2014-05-06 22:34 ob-lua.el dieter
2014-05-06 22:46 ` ob-lua.el Bastien
2014-05-09 20:23 ` ob-lua.el Dieter Schoen
2014-05-06 23:25 ` ob-lua.el John Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4xrxt26.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=dieter@schoen.or.at \
--cc=emacs-orgmode@gnu.org \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).