emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Sami Airaksinen <samiaira@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el: org-babel-load-file loads first tangle file
Date: Fri, 30 Jan 2015 10:44:42 +0100	[thread overview]
Message-ID: <87y4okpppx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <54CAAAE0.208@gmail.com> (Sami Airaksinen's message of "Thu, 29 Jan 2015 23:49:20 +0200")

Hello,

Sami Airaksinen <samiaira@gmail.com> writes:

> I use quite sophisticated (read complicated) initialization of my emacs.
> Now I finally updated my emacs and org-mode upto date and found out that
> org-babel-load-file doesn't work as previously.
>
> I don't know if you have already noticed but if your tangled source
> org-mode file has multiple target files for the tangle blocks, it loads
> the file which was found last. This most often isn't the file name that
> was given as input. There could be more generic solution to this, but I
> though that it might be best to keep this patching simple as possible.
>
> This is my first patch proposal so I hope I'm doing right and adding it
> as an attachment to this post

It looks good, thank you.

However, could you also add a comment above the modified line in order
to explain the car+last call?

[...]

> Suggestion from a patch proposal by Sami Airaksinen

The line above is not necessary since you're the author of the patch
anyway.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2015-01-30  9:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 21:49 [PATCH] org.el: org-babel-load-file loads first tangle file Sami Airaksinen
2015-01-30  9:44 ` Nicolas Goaziou [this message]
2015-01-30 12:55   ` Sami Airaksinen
2015-01-30 17:13     ` Nicolas Goaziou
2015-01-31 22:20       ` Sami Airaksinen
2015-01-31 23:04         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4okpppx.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=samiaira@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).