From: Sami Airaksinen <samiaira@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el: org-babel-load-file loads first tangle file
Date: Sun, 01 Feb 2015 00:20:01 +0200 [thread overview]
Message-ID: <54CD5511.7010205@gmail.com> (raw)
In-Reply-To: <87twz8p4yf.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 696 bytes --]
On 01/30/2015 07:13 PM, Nicolas Goaziou wrote:
> Sami Airaksinen <samiaira@gmail.com> writes:
>
>> I got confused, do you want a comment in the source code or in the commit
>> message?
> The former.
>
>> So comment in the source code would be something like,
>> "tangle-file traversal returns reversed list of tangled files and we want
>> to evaluate the first target"
> That's fine.
>
>> If explanation is for car+last combo: (car (last ...)) the car is needed
>> because (last ...) returns the last link which is list of one element.
> No it isn't about car+last but why we're interested in the last element
> instead of the first one.
>
> Thanks,
--
Sami Airaksinen
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-org.el-org-babel-load-file-loads-first-tangle-file.patch --]
[-- Type: text/x-patch; name="0001-org.el-org-babel-load-file-loads-first-tangle-file.patch", Size: 1417 bytes --]
From 6fcb4b222e308c97d4c90b96ac73234c1951f307 Mon Sep 17 00:00:00 2001
From: Sami Airaksinen <samiaira@gmail.com>
Date: Thu, 29 Jan 2015 23:10:02 +0200
Subject: [PATCH] org.el: org-babel-load-file loads first tangle file
(org-babel-load-file): When org-mode FILE has multiple target files
for tangle blocks, `exported-file' will be set to last found
target file, which might not be the `file'.
Therefore fix for this bug is to select the last element of that
tangled file list, which is the tangle target file of the first found
tangle block, most typically the `file'.
TINYCHANGE
---
lisp/org.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index b0e4380..e87de90 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -235,8 +235,9 @@ file to byte-code before it is loaded."
;; tangle if the org-mode file is newer than the elisp file
(unless (and (file-exists-p exported-file)
(> (funcall age file) (funcall age exported-file)))
+ ;; tangle-file traversal returns reversed list of tangled files and we want to evaluate the first target
(setq exported-file
- (car (org-babel-tangle-file file exported-file "emacs-lisp"))))
+ (car (last (org-babel-tangle-file file exported-file "emacs-lisp")))))
(message "%s %s"
(if compile
(progn (byte-compile-file exported-file 'load)
--
1.9.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-31 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 21:49 [PATCH] org.el: org-babel-load-file loads first tangle file Sami Airaksinen
2015-01-30 9:44 ` Nicolas Goaziou
2015-01-30 12:55 ` Sami Airaksinen
2015-01-30 17:13 ` Nicolas Goaziou
2015-01-31 22:20 ` Sami Airaksinen [this message]
2015-01-31 23:04 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CD5511.7010205@gmail.com \
--to=samiaira@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).