Re: [PATCH] Wash output of org-encrypt-entry, take 3

[David Maus <dmaus@ictsoc.de>]

[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]

At Mon, 21 Mar 2011 14:54:09 +0100,
Julien Danjou wrote:
> 
> [1  <text/plain; utf-8 (quoted-printable)>]
> On Fri, Mar 18 2011, Óscar Fuentes wrote:
> 
> > The first line (Version:...) can change from machine to machine and over
> > time (as gpg is updated with a new version.) This is problematic when
> > the file is stored under version control, because as you decrypt and
> > encrypt an entry that line will change and create differences among the
> > file on the workspace and the file stored on VC.
> 
> This is true only if you modify the content of the entry, so I'm not
> sure there's a real harm done here.

gpg --no-emit-version

Can be configured in gpg.conf.

> 
> > Second, the empty line just wastes space and it is plain ugly once we
> > remove the first one with the Version text.
> 
> This line is required by the protocol.

+1

> 
> > Finally, on some systems (mostly Windows) depending on how your Emacs
> > and gpg are configured, ^M characters may appear at the end of every
> > line of gpg output once it is inserted on the Emacs buffer. This happens
> > when the buffer uses Unix line-endings but gpg uses DOS line-endings.
> 
> I do not feel the right place and/or way to fix and encoding bug.

Don't think this is a bug at all: The gpg executable (as well as plain
Emacs btw ) uses whatever is deemed the line-ending signature of the
operating system. Washing out the ^M overrules the system settings and
enforces the assumption that lines are terminated by a single
newline. This sound like a bad idea: You might get the opposite
situation -- the Org file uses "DOS"-style CRLF and the encrypted
block doesn't.

Best,
  -- David
-- 
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]