From: Julien Danjou <julien@danjou.info>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Wash output of org-encrypt-entry, take 3
Date: Mon, 21 Mar 2011 14:54:09 +0100 [thread overview]
Message-ID: <sa37hbsefzy.fsf@cigue.easter-eggs.fr> (raw)
In-Reply-To: <87bp182hiw.fsf@wanadoo.es> ("Óscar Fuentes"'s message of "Fri, 18 Mar 2011 23:25:11 +0100")
[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]
On Fri, Mar 18 2011, Óscar Fuentes wrote:
> The first line (Version:...) can change from machine to machine and over
> time (as gpg is updated with a new version.) This is problematic when
> the file is stored under version control, because as you decrypt and
> encrypt an entry that line will change and create differences among the
> file on the workspace and the file stored on VC.
This is true only if you modify the content of the entry, so I'm not
sure there's a real harm done here.
> Second, the empty line just wastes space and it is plain ugly once we
> remove the first one with the Version text.
This line is required by the protocol.
> Finally, on some systems (mostly Windows) depending on how your Emacs
> and gpg are configured, ^M characters may appear at the end of every
> line of gpg output once it is inserted on the Emacs buffer. This happens
> when the buffer uses Unix line-endings but gpg uses DOS line-endings.
I do not feel the right place and/or way to fix and encoding bug.
> +(defun org-crypt-wash-encrypted-string (str)
> + "Remove superfluos and annoying text from the encrypted string."
> + (with-temp-buffer
> + (insert str)
> + (goto-char (point-min))
> + (while (re-search-forward "^Version:.*$\\|\^M\\|^\n" nil t)
> + (replace-match ""))
> + (buffer-string)))
> +
Ultimately, maybe simpler with `string-match'.
--
Julien Danjou
❱ http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2011-03-21 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 22:25 [PATCH] Wash output of org-encrypt-entry, take 3 Óscar Fuentes
2011-03-20 20:34 ` Bernt Hansen
2011-03-20 21:10 ` Bernt Hansen
2011-03-21 13:54 ` Julien Danjou [this message]
2011-04-10 20:08 ` David Maus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sa37hbsefzy.fsf@cigue.easter-eggs.fr \
--to=julien@danjou.info \
--cc=emacs-orgmode@gnu.org \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).