Shouldn't comment-region protect from export ?

Shouldn't comment-region protect from export ?

[William LÉCHELLE]

Hi list :)

Using org-mode for export (to pdf), I find myself using comment-region often
enough, in sections meant to be exported, on indented text lines (e.g. for
drafting). This inserts "# " at the "beginning" of the line, after the
indentation, thus not achieving what I wanted comment-region to do
(i.e. "don't export this"). 

I suggest "#+ " to be inserted instead, for that seems to me to be the correct
prefix for indented comments. I'd rather keep it all indented and not having #
at position 0 (breaking what follows' default indentation, æsthetics apart).

I don't remember having overridden any comment-prefix variable of any sort
(but maybe I did, I just don't know what that variable would be).

Am I doing something wrong, or are my expectations misplaced ? (is there a
meaning to "comment" for org text I can't think of that # satisfies and #+
wouldn't, maybe ?)

William

Re: Shouldn't comment-region protect from export ?

[Bastien]

Hi William,

William LÉCHELLE <william.lechelle@ens-lyon.fr> writes:

> Using org-mode for export (to pdf), I find myself using comment-region often
> enough, in sections meant to be exported, on indented text lines (e.g. for
> drafting). This inserts "# " at the "beginning" of the line, after the
> indentation, thus not achieving what I wanted comment-region to do
> (i.e. "don't export this"). 

This is fixed now, thanks.

-- 
 Bastien

Re: Shouldn't comment-region protect from export ?

[William Léchelle]

On Thu, 02 Aug 2012 18:40:04 +0200, Bastien spake thus:
>William LÉCHELLE <william.lechelle@ens-lyon.fr> writes:

>> Using org-mode for export (to pdf), I find myself using comment-region often
>> enough, in sections meant to be exported, on indented text lines (e.g. for
>> drafting). This inserts "# " at the "beginning" of the line, after the
>> indentation, thus not achieving what I wanted comment-region to do
>> (i.e. "don't export this"). 

>This is fixed now, thanks.

Having just pulled from git, comment-region still gets me indented "#" lines,
which still get exported (using the default exporter).

How is it supposed to be fixed ?

Re: Shouldn't comment-region protect from export ?

[Nicolas Goaziou]

Hello,

William Léchelle <william.lechelle@ens-lyon.fr> writes:

> Having just pulled from git, comment-region still gets me indented "#" lines,
> which still get exported (using the default exporter).
>
> How is it supposed to be fixed ?

I have pushed a patch against current exporter. Inlined comments should
be properly removed now.

Thanks for reporting this.


Regards,

-- 
Nicolas Goaziou

Re: Shouldn't comment-region protect from export ?

[William Léchelle]

On Mon, 27 Aug 2012 11:24:21 +0200, Nicolas Goaziou spake thus:

>> Having just pulled from git, comment-region still gets me indented "#" lines,
>> which still get exported (using the default exporter).
>>
>> How is it supposed to be fixed ?

>I have pushed a patch against current exporter. Inlined comments should
>be properly removed now.

Thanks, indeed, these no longer appear.

Only now, my #+latex_header: is not properly exported, and rather protected
and displayed in the document. I didn't check before the patch, but I guess it
worked all right. I'm using subtree export, in case that matters.

Re: Shouldn't comment-region protect from export ?

[Nicolas Goaziou]

Hello,

William Léchelle <william.lechelle@ens-lyon.fr> writes:

> Only now, my #+latex_header: is not properly exported, and rather protected
> and displayed in the document. I didn't check before the patch, but I guess it
> worked all right. I'm using subtree export, in case that matters.

I knew I shouldn't have messed again with old exporter...

Anyway, I pushed a fix to the fix. Does it behave as expected now?


Regards,

-- 
Nicolas Goaziou

Re: Shouldn't comment-region protect from export ?

[William Léchelle]

On Mon, 27 Aug 2012 12:16:22 +0200, Nicolas Goaziou spake thus:
>William Léchelle <william.lechelle@ens-lyon.fr> writes:

>> Only now, my #+latex_header: is not properly exported, and rather protected
>> and displayed in the document. I didn't check before the patch, but I guess it
>> worked all right. I'm using subtree export, in case that matters.

>I knew I shouldn't have messed again with old exporter...

>Anyway, I pushed a fix to the fix. Does it behave as expected now?

Yes, it works perfectly, thank you very much !

--
William

Re: Shouldn't comment-region protect from export ?

[Bastien]

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> I knew I shouldn't have messed again with old exporter...

Don't worry, we will get rid of them soon...

I *know* what relief this will be for you!  :)

-- 
 Bastien