emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Shouldn't comment-region protect from export ?
@ 2012-07-07  2:47 William LÉCHELLE
  2012-08-02 16:40 ` Bastien
  0 siblings, 1 reply; 8+ messages in thread
From: William LÉCHELLE @ 2012-07-07  2:47 UTC (permalink / raw)
  To: emacs-orgmode

Hi list :)

Using org-mode for export (to pdf), I find myself using comment-region often
enough, in sections meant to be exported, on indented text lines (e.g. for
drafting). This inserts "# " at the "beginning" of the line, after the
indentation, thus not achieving what I wanted comment-region to do
(i.e. "don't export this"). 

I suggest "#+ " to be inserted instead, for that seems to me to be the correct
prefix for indented comments. I'd rather keep it all indented and not having #
at position 0 (breaking what follows' default indentation, æsthetics apart).

I don't remember having overridden any comment-prefix variable of any sort
(but maybe I did, I just don't know what that variable would be).

Am I doing something wrong, or are my expectations misplaced ? (is there a
meaning to "comment" for org text I can't think of that # satisfies and #+
wouldn't, maybe ?)

William

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Shouldn't comment-region protect from export ?
  2012-07-07  2:47 Shouldn't comment-region protect from export ? William LÉCHELLE
@ 2012-08-02 16:40 ` Bastien
  2012-08-27  8:09   ` William Léchelle
  0 siblings, 1 reply; 8+ messages in thread
From: Bastien @ 2012-08-02 16:40 UTC (permalink / raw)
  To: William LÉCHELLE; +Cc: emacs-orgmode

Hi William,

William LÉCHELLE <william.lechelle@ens-lyon.fr> writes:

> Using org-mode for export (to pdf), I find myself using comment-region often
> enough, in sections meant to be exported, on indented text lines (e.g. for
> drafting). This inserts "# " at the "beginning" of the line, after the
> indentation, thus not achieving what I wanted comment-region to do
> (i.e. "don't export this"). 

This is fixed now, thanks.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Shouldn't comment-region protect from export ?
  2012-08-02 16:40 ` Bastien
@ 2012-08-27  8:09   ` William Léchelle
  2012-08-27  9:24     ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: William Léchelle @ 2012-08-27  8:09 UTC (permalink / raw)
  To: emacs-orgmode

On Thu, 02 Aug 2012 18:40:04 +0200, Bastien spake thus:
>William LÉCHELLE <william.lechelle@ens-lyon.fr> writes:

>> Using org-mode for export (to pdf), I find myself using comment-region often
>> enough, in sections meant to be exported, on indented text lines (e.g. for
>> drafting). This inserts "# " at the "beginning" of the line, after the
>> indentation, thus not achieving what I wanted comment-region to do
>> (i.e. "don't export this"). 

>This is fixed now, thanks.

Having just pulled from git, comment-region still gets me indented "#" lines,
which still get exported (using the default exporter).

How is it supposed to be fixed ?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Shouldn't comment-region protect from export ?
  2012-08-27  8:09   ` William Léchelle
@ 2012-08-27  9:24     ` Nicolas Goaziou
  2012-08-27  9:49       ` William Léchelle
  0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2012-08-27  9:24 UTC (permalink / raw)
  To: William Léchelle; +Cc: emacs-orgmode

Hello,

William Léchelle <william.lechelle@ens-lyon.fr> writes:

> Having just pulled from git, comment-region still gets me indented "#" lines,
> which still get exported (using the default exporter).
>
> How is it supposed to be fixed ?

I have pushed a patch against current exporter. Inlined comments should
be properly removed now.

Thanks for reporting this.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Shouldn't comment-region protect from export ?
  2012-08-27  9:24     ` Nicolas Goaziou
@ 2012-08-27  9:49       ` William Léchelle
  2012-08-27 10:16         ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: William Léchelle @ 2012-08-27  9:49 UTC (permalink / raw)
  To: emacs-orgmode, Nicolas Goaziou

On Mon, 27 Aug 2012 11:24:21 +0200, Nicolas Goaziou spake thus:

>> Having just pulled from git, comment-region still gets me indented "#" lines,
>> which still get exported (using the default exporter).
>>
>> How is it supposed to be fixed ?

>I have pushed a patch against current exporter. Inlined comments should
>be properly removed now.

Thanks, indeed, these no longer appear.

Only now, my #+latex_header: is not properly exported, and rather protected
and displayed in the document. I didn't check before the patch, but I guess it
worked all right. I'm using subtree export, in case that matters.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Shouldn't comment-region protect from export ?
  2012-08-27  9:49       ` William Léchelle
@ 2012-08-27 10:16         ` Nicolas Goaziou
  2012-08-27 10:26           ` William Léchelle
  2012-08-27 16:19           ` Bastien
  0 siblings, 2 replies; 8+ messages in thread
From: Nicolas Goaziou @ 2012-08-27 10:16 UTC (permalink / raw)
  To: William Léchelle; +Cc: emacs-orgmode

Hello,

William Léchelle <william.lechelle@ens-lyon.fr> writes:

> Only now, my #+latex_header: is not properly exported, and rather protected
> and displayed in the document. I didn't check before the patch, but I guess it
> worked all right. I'm using subtree export, in case that matters.

I knew I shouldn't have messed again with old exporter...

Anyway, I pushed a fix to the fix. Does it behave as expected now?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Shouldn't comment-region protect from export ?
  2012-08-27 10:16         ` Nicolas Goaziou
@ 2012-08-27 10:26           ` William Léchelle
  2012-08-27 16:19           ` Bastien
  1 sibling, 0 replies; 8+ messages in thread
From: William Léchelle @ 2012-08-27 10:26 UTC (permalink / raw)
  To: Nicolas Goaziou, emacs-orgmode

On Mon, 27 Aug 2012 12:16:22 +0200, Nicolas Goaziou spake thus:
>William Léchelle <william.lechelle@ens-lyon.fr> writes:

>> Only now, my #+latex_header: is not properly exported, and rather protected
>> and displayed in the document. I didn't check before the patch, but I guess it
>> worked all right. I'm using subtree export, in case that matters.

>I knew I shouldn't have messed again with old exporter...

>Anyway, I pushed a fix to the fix. Does it behave as expected now?

Yes, it works perfectly, thank you very much !

--
William

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Shouldn't comment-region protect from export ?
  2012-08-27 10:16         ` Nicolas Goaziou
  2012-08-27 10:26           ` William Léchelle
@ 2012-08-27 16:19           ` Bastien
  1 sibling, 0 replies; 8+ messages in thread
From: Bastien @ 2012-08-27 16:19 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode, William Léchelle

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> I knew I shouldn't have messed again with old exporter...

Don't worry, we will get rid of them soon...

I *know* what relief this will be for you!  :)

-- 
 Bastien

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-08-27 16:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-07  2:47 Shouldn't comment-region protect from export ? William LÉCHELLE
2012-08-02 16:40 ` Bastien
2012-08-27  8:09   ` William Léchelle
2012-08-27  9:24     ` Nicolas Goaziou
2012-08-27  9:49       ` William Léchelle
2012-08-27 10:16         ` Nicolas Goaziou
2012-08-27 10:26           ` William Léchelle
2012-08-27 16:19           ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).