emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Chunyang Xu <mail@xuchunyang.me>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: Can't execute C code block from remote directory [9.0.5 (release_9.0.5-401-g86ff11 @ /Users/xcy/src/org-mode/lisp/)]
Date: Wed, 05 Apr 2017 10:11:31 +0200	[thread overview]
Message-ID: <87wpazz32k.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2o9wern8r.fsf@xuchunyang.me> (Chunyang Xu's message of "Mon, 03 Apr 2017 14:58:28 +0800")

Hello,

Chunyang Xu <mail@xuchunyang.me> writes:

> Here is a patch which can fix the issue.

Thank you.

> From e42b22f74c2f04a4d8e7eec0a6bdacbd08bebf12 Mon Sep 17 00:00:00 2001
> From: Chunyang Xu <mail@xuchunyang.me>
> Date: Mon, 3 Apr 2017 14:46:51 +0800
> Subject: [PATCH] ob-C: Fix remote executing
>
> * lisp/ob-C.el (org-babel-C-execute): Process remote bin file.
>
> TINYCHANGE
> ---
>  lisp/ob-C.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/ob-C.el b/lisp/ob-C.el
> index 795bcb2b7..e54e17492 100644
> --- a/lisp/ob-C.el
> +++ b/lisp/ob-C.el
> @@ -161,7 +161,7 @@ or `org-babel-execute:C++' or `org-babel-execute:D'."
>  	   (org-babel-eval
>  	    (pcase org-babel-c-variant
>  	      ((or `c `cpp)
> -	       (concat tmp-bin-file cmdline))
> +	       (concat (org-babel-process-file-name tmp-bin-file) cmdline))

I see that `tmp-bin-file' is used a couple other times in the body.
Would it make sense to wrap the initial binding within
`org-babel-process-file-name' instead of doing it only for this
occurrence?

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2017-04-05  8:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 15:22 Bug: Can't execute C code block from remote directory [9.0.5 (release_9.0.5-401-g86ff11 @ /Users/xcy/src/org-mode/lisp/)] Chunyang Xu
2017-04-01 17:27 ` Scatter-gather idea Bob Newell
2017-04-01 18:41   ` John Kitchin
2017-04-01 20:12     ` Bob Newell
2017-04-03  2:48       ` Samuel Wales
2017-04-03  4:34         ` Bob Newell
2017-04-05  5:06           ` Yasushi SHOJI
2017-04-05 15:22             ` Nick Dokos
2017-04-06 18:28               ` Bob Newell
2017-04-06 19:19                 ` Nick Dokos
2017-04-06 19:40                   ` John Kitchin
2017-04-10  8:46           ` Daniel Clemente
2017-04-01 18:47   ` Bingo
2017-04-03  6:58 ` Bug: Can't execute C code block from remote directory [9.0.5 (release_9.0.5-401-g86ff11 @ /Users/xcy/src/org-mode/lisp/)] Chunyang Xu
2017-04-05  8:11   ` Nicolas Goaziou [this message]
2017-04-05 11:49     ` Chunyang Xu
2017-04-07 16:15       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpazz32k.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@xuchunyang.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).