Re: ob-lilypond

[Eric Schulte <schulte.eric@gmail.com>]

Martyn Jago <martyn.jago@btinternet.com> writes:

> Hi
>
>> 
>> That's good to hear.  Are you up for trying to merge them into the rest
>> of the Org-mode test suite?  This should be as simple as placing any
>> org-mode example files you have in
>> 
>> org-mode/testing/examples/
>> 
>> placing the .el file defining your tests into
>> 
>> org-mode/testing/lisp/
>> 
>> and renaming all of your tests so that they start with the prefix
>> "ob-lilypond/"
>> 
>> I fully understand if you don't have the time to do this, and I should
>> be able to take a shot at it some time in the not-too-distant future.
>
> Hopefully this patch will work for you...
>

Yes, this patch applied without error, and the test suite passes all
tests.  Thanks for contributing and for greatly increasing the size of
the Org-mode test suite.

>
> It looks like noweb parsing has very recently become very brittle, 
> since it broke the noweb in my lilypond example. 
> This does not appear to be restricted to lilypond blocks.
>
> The error is (wrong-type-argument consp nil)
>
> I fixed for my songs by changing...
>
> #+srcname: gen_arpeggio(key,root)
>
> to...
>
> #+srcname: gen_arpeggio (key,root)
>
> and... 
>
> <<gen_arpeggio(key="c",root="c")>>
>
> to...
>
> <<gen_arpeggio (key="c",root="c")>>
>
> I believe #+call: is affected too.
>
> Unfortunately I won't be able to investigate further until next week.
>

I can't reproduce this problem, for example the following works for me
on the latest version of Org-mode.  I think perhaps you may not be on
the latest git HEAD.

Thanks again for this great contribution -- Eric

** define a block with a name for noweb expansion
   :PROPERTIES:
   :tangle:   yes
   :noweb:    yes
   :END:

#+source: simple(something="something")
#+begin_src emacs-lisp
  something
#+end_src

another block including the first block
#+begin_src emacs-lisp
  <<simple(something="something else")>>
#+end_src

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/