From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: ob-lilypond Date: Fri, 01 Jul 2011 12:27:12 -0700 Message-ID: <87vcvllpxh.fsf@gmail.com> References: <87k4c79kdg.fsf@gmail.com> <87d3hyl15p.fsf@gnu.org> <874o3al0ib.fsf@gnu.org> <87zkl1bs7s.fsf@gmail.com> <87r56c5ogi.fsf@gmail.com> <87ei2b8a1z.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:41347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qck64-0005uQ-IO for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 16:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qck62-0007QX-H5 for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 16:13:52 -0400 Received: from mail-pv0-f169.google.com ([74.125.83.169]:44672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qck62-0007Ol-4Z for emacs-orgmode@gnu.org; Fri, 01 Jul 2011 16:13:50 -0400 Received: by mail-pv0-f169.google.com with SMTP id 12so3771188pvc.0 for ; Fri, 01 Jul 2011 13:13:49 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: emacs-orgmode@gnu.org Martyn Jago writes: > Hi > >> >> That's good to hear. Are you up for trying to merge them into the rest >> of the Org-mode test suite? This should be as simple as placing any >> org-mode example files you have in >> >> org-mode/testing/examples/ >> >> placing the .el file defining your tests into >> >> org-mode/testing/lisp/ >> >> and renaming all of your tests so that they start with the prefix >> "ob-lilypond/" >> >> I fully understand if you don't have the time to do this, and I should >> be able to take a shot at it some time in the not-too-distant future. > > Hopefully this patch will work for you... > Yes, this patch applied without error, and the test suite passes all tests. Thanks for contributing and for greatly increasing the size of the Org-mode test suite. > > It looks like noweb parsing has very recently become very brittle, > since it broke the noweb in my lilypond example. > This does not appear to be restricted to lilypond blocks. > > The error is (wrong-type-argument consp nil) > > I fixed for my songs by changing... > > #+srcname: gen_arpeggio(key,root) > > to... > > #+srcname: gen_arpeggio (key,root) > > and... > > <> > > to... > > <> > > I believe #+call: is affected too. > > Unfortunately I won't be able to investigate further until next week. > I can't reproduce this problem, for example the following works for me on the latest version of Org-mode. I think perhaps you may not be on the latest git HEAD. Thanks again for this great contribution -- Eric ** define a block with a name for noweb expansion :PROPERTIES: :tangle: yes :noweb: yes :END: #+source: simple(something="something") #+begin_src emacs-lisp something #+end_src another block including the first block #+begin_src emacs-lisp <> #+end_src -- Eric Schulte http://cs.unm.edu/~eschulte/