Bug: Cloning tasks deletes clock time in the original [7.7 (release_7.7-571-gf558105)]

Bug: Cloning tasks deletes clock time in the original [7.7 (release_7.7-571-gf558105)]

[Bernt Hansen]

Consider the following org file:

--8<---------------cut here---------------start------------->8---
* Orig Task 1
SCHEDULED: <2011-11-19 Sat +1w>
:LOGBOOK:
- Note taken on [2011-11-19 Sat 21:24] \\
  foo
CLOCK: [2011-11-18 Fri 20:30]--[2011-11-18 Fri 21:24] =>  0:54
CLOCK: [2011-11-19 Sat 20:23]--[2011-11-19 Sat 21:23] =>  1:00
:END:
[2011-11-19 Sat 21:23]
--8<---------------cut here---------------end--------------->8---

This is a repeating task with some clock time on it.

Now I need to change the 2nd occurrence from now so I clone the task to
create 2 more followed by the repeater as follows:

On the task do C-c C-x c 2 RET +1w RET

Now I get this so I can edit one of the individual entries

--8<---------------cut here---------------start------------->8---
* Orig Task 1
SCHEDULED: <2011-11-19 Sat>
:LOGBOOK:
- Note taken on [2011-11-19 Sat 21:24] \\
  foo
:END:
[2011-11-19 Sat 21:23]
* Orig Task 1
SCHEDULED: <2011-11-26 Sat>
:LOGBOOK:
- Note taken on [2011-11-26 Sat 21:24] \\
  foo
:END:
[2011-11-26 Sat 21:23]
* Orig Task 1
SCHEDULED: <2011-12-03 Sat>
:LOGBOOK:
- Note taken on [2011-12-03 Sat 21:24] \\
  foo
:END:
[2011-12-03 Sat 21:23]
* Orig Task 1
SCHEDULED: <2011-12-10 Sat +1w>
:LOGBOOK:
- Note taken on [2011-12-10 Sat 21:24] \\
  foo
:END:
[2011-12-10 Sat 21:23]
--8<---------------cut here---------------end--------------->8---

I have the entries I want but my original clock lines have been deleted.
I would expect this behaviour for the newly created clones only - not
the original entry.

I ran into this for a weekly meeting task I cloned and ended up
recovering my clock lines from my hourly git repository but this
shouldn't be necessary.

I'm also not sure exactly why I get 3 entries when I ask for two --
maybe that's a special case of the repeater in the original task but it
feels weird.

Regards,
Bernt

Emacs  : GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0)
 of 2010-12-11 on raven, modified by Debian
Package: Org-mode version 7.7 (release_7.7-571-gf558105)

Re: Bug: Cloning tasks deletes clock time in the original [7.7 (release_7.7-571-gf558105)]

[David Maus]

[-- Attachment #1: Type: text/plain, Size: 2445 bytes --]

At Sat, 19 Nov 2011 21:37:08 -0500,
Bernt Hansen wrote:
>
>
> Consider the following org file:
>
> --8<---------------cut here---------------start------------->8---
> * Orig Task 1
> SCHEDULED: <2011-11-19 Sat +1w>
> :LOGBOOK:
> - Note taken on [2011-11-19 Sat 21:24] \\
>   foo
> CLOCK: [2011-11-18 Fri 20:30]--[2011-11-18 Fri 21:24] =>  0:54
> CLOCK: [2011-11-19 Sat 20:23]--[2011-11-19 Sat 21:23] =>  1:00
> :END:
> [2011-11-19 Sat 21:23]
> --8<---------------cut here---------------end--------------->8---
>
> This is a repeating task with some clock time on it.
>
> Now I need to change the 2nd occurrence from now so I clone the task to
> create 2 more followed by the repeater as follows:
>
> On the task do C-c C-x c 2 RET +1w RET
>
> Now I get this so I can edit one of the individual entries
>
> --8<---------------cut here---------------start------------->8---
> * Orig Task 1
> SCHEDULED: <2011-11-19 Sat>
> :LOGBOOK:
> - Note taken on [2011-11-19 Sat 21:24] \\
>   foo
> :END:
> [2011-11-19 Sat 21:23]
> * Orig Task 1
> SCHEDULED: <2011-11-26 Sat>
> :LOGBOOK:
> - Note taken on [2011-11-26 Sat 21:24] \\
>   foo
> :END:
> [2011-11-26 Sat 21:23]
> * Orig Task 1
> SCHEDULED: <2011-12-03 Sat>
> :LOGBOOK:
> - Note taken on [2011-12-03 Sat 21:24] \\
>   foo
> :END:
> [2011-12-03 Sat 21:23]
> * Orig Task 1
> SCHEDULED: <2011-12-10 Sat +1w>
> :LOGBOOK:
> - Note taken on [2011-12-10 Sat 21:24] \\
>   foo
> :END:
> [2011-12-10 Sat 21:23]
> --8<---------------cut here---------------end--------------->8---
>
> I have the entries I want but my original clock lines have been deleted.
> I would expect this behaviour for the newly created clones only - not
> the original entry.
>
> I ran into this for a weekly meeting task I cloned and ended up
> recovering my clock lines from my hourly git repository but this
> shouldn't be necessary.
>
> I'm also not sure exactly why I get 3 entries when I ask for two --
> maybe that's a special case of the repeater in the original task but it
> feels weird.

I can confirm this bug for

Org-mode version 7.7 (release_7.7.583.gedef1)

GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of
2010-12-11 on raven, modified by Debian

Looks like 516b2fbb8763788585ac6a9f60ad7d51c4b0aab3 is the culprit:
`template' also contains the original entry.

I'll see to provide a fix for this.

Best,
  -- David

--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]

Re: Bug: Cloning tasks deletes clock time in the original [7.7 (release_7.7-571-gf558105)]

[David Maus]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

At Sat, 19 Nov 2011 21:37:08 -0500,
Bernt Hansen wrote:
>
> I have the entries I want but my original clock lines have been deleted.
> I would expect this behaviour for the newly created clones only - not
> the original entry.

Pushed a fix for this problem. Could you check it works out for you?

>
> I'm also not sure exactly why I get 3 entries when I ask for two --
> maybe that's a special case of the repeater in the original task but it
> feels weird.

Yes, it's the repeater: You get one for clone for free (C-h f
org-clone-subtree-with-time-shift). I agree it's not that intuitive.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #2: Type: application/pgp-signature, Size: 230 bytes --]

Re: Bug: Cloning tasks deletes clock time in the original [7.7 (release_7.7-571-gf558105)]

[Bernt Hansen]

David Maus <dmaus@ictsoc.de> writes:

> At Sat, 19 Nov 2011 21:37:08 -0500,
> Bernt Hansen wrote:
>>
>> I have the entries I want but my original clock lines have been deleted.
>> I would expect this behaviour for the newly created clones only - not
>> the original entry.
>
> Pushed a fix for this problem. Could you check it works out for you?
>

Hi David,

This works for me.  Thanks!

Regards,
Bernt