patch for ob-sql and postgresql for supporting :colnames

patch for ob-sql and postgresql for supporting :colnames

[Joost Helberg]

hi,

the :colnames header argument is not honoured for postgresql. Hence the
following patch for ob-sql.el. The command-line tool psql supports the
option -t for not displaying column-names. The default behavious is not
changed with this patch.

126,127c126
<                                 "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\"  -f %s -o %s %s"
<                                   (if colnames-p "" "-t")
---
>                                 "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\"  -f %s -o %s %s"

Can anyone suggest to me why this should not be in ob-sql.el? It is
already implemented for the mysql engine (via -N).

regards,

Joost

-- 
Snow B.V.        http://snow.nl

Re: patch for ob-sql and postgresql for supporting :colnames

[Eric Schulte]

Applied, thanks.

Joost Helberg <joost@snow.nl> writes:

> hi,
>
> the :colnames header argument is not honoured for postgresql. Hence the
> following patch for ob-sql.el. The command-line tool psql supports the
> option -t for not displaying column-names. The default behavious is not
> changed with this patch.
>
> 126,127c126
> <                                 "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\"  -f %s -o %s %s"
> <                                   (if colnames-p "" "-t")
> ---
>>                                 "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\"  -f %s -o %s %s"
>
> Can anyone suggest to me why this should not be in ob-sql.el? It is
> already implemented for the mysql engine (via -N).
>
> regards,
>
> Joost

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

Re: patch for ob-sql and postgresql for supporting :colnames

[Joost Helberg]

Eric,

it's not in org-plus-contrib-20140203. Was it lost somehow (also my fix
for stopping on error is not in)?

regards,

Joost

>>>>> "schulte" == schulte eric <schulte.eric@gmail.com> writes:
 > From: schulte.eric@gmail.com
 > To: joost@snow.nl
 > Cc: emacs-orgmode@gnu.org
 > Subject: Re: [O] patch for ob-sql and postgresql for supporting
 > Date: 08-Jan-14 17:58

 > Applied, thanks.

 > Joost Helberg <joost@snow.nl> writes:

 >> hi,
 >> 
 >> the :colnames header argument is not honoured for postgresql. Hence the
 >> following patch for ob-sql.el. The command-line tool psql supports the
 >> option -t for not displaying column-names. The default behavious is not
 >> changed with this patch.
 >> 
 >> 126,127c126
 >> <                                 "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\"  -f %s -o %s %s"
 >> <                                   (if colnames-p "" "-t")
 >> ---
 >>> "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\"  -f %s -o %s %s"
 >> 
 >> Can anyone suggest to me why this should not be in ob-sql.el? It is
 >> already implemented for the mysql engine (via -N).
 >> 
 >> regards,
 >> 
 >> Joost

 > -- 
 > Eric Schulte
 > https://cs.unm.edu/~eschulte
 > PGP: 0x614CA05D


-- 
Snow B.V.

Re: patch for ob-sql and postgresql for supporting :colnames

[Bastien]

Hi Joost,

Joost Helberg <joost@snow.nl> writes:

> it's not in org-plus-contrib-20140203. Was it lost somehow (also my fix
> for stopping on error is not in)?

The change you suggested is in the master branch, not in the maint
branch, which is for bugfixes only.  IMO the change is more a feature
enhancement than a bugfix, hence the fact it's in master.  Also, we
are more strict with "bugfixes" right now because all our fixes
will go into Emacs 24.4, which is in feature freeze right now.

-- 
 Bastien

Re: patch for ob-sql and postgresql for supporting :colnames

[Joost Helberg]

Bastien,

OK, I understand.

regards,

Joost

>>>>> "bzg" == bzg  <bzg@gnu.org> writes:
 > From: bzg@gnu.org
 > To: joost@snow.nl
 > Cc: schulte.eric@gmail.com, emacs-orgmode@gnu.org
 > Subject: Re: patch for ob-sql and postgresql for supporting :colnames
 > Date: 03-Feb-14 15:54

 > Hi Joost,

 > Joost Helberg <joost@snow.nl> writes:

 >> it's not in org-plus-contrib-20140203. Was it lost somehow (also my fix
 >> for stopping on error is not in)?

 > The change you suggested is in the master branch, not in the maint
 > branch, which is for bugfixes only.  IMO the change is more a feature
 > enhancement than a bugfix, hence the fact it's in master.  Also, we
 > are more strict with "bugfixes" right now because all our fixes
 > will go into Emacs 24.4, which is in feature freeze right now.

 > -- 
 >  Bastien


-- 
Snow B.V.