* patch for ob-sql and postgresql for supporting :colnames
@ 2014-01-08 12:58 Joost Helberg
2014-01-08 16:58 ` Eric Schulte
0 siblings, 1 reply; 5+ messages in thread
From: Joost Helberg @ 2014-01-08 12:58 UTC (permalink / raw)
To: Org-Mode
hi,
the :colnames header argument is not honoured for postgresql. Hence the
following patch for ob-sql.el. The command-line tool psql supports the
option -t for not displaying column-names. The default behavious is not
changed with this patch.
126,127c126
< "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\" -f %s -o %s %s"
< (if colnames-p "" "-t")
---
> "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\" -f %s -o %s %s"
Can anyone suggest to me why this should not be in ob-sql.el? It is
already implemented for the mysql engine (via -N).
regards,
Joost
--
Snow B.V. http://snow.nl
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch for ob-sql and postgresql for supporting :colnames
2014-01-08 12:58 patch for ob-sql and postgresql for supporting :colnames Joost Helberg
@ 2014-01-08 16:58 ` Eric Schulte
2014-02-03 13:11 ` Joost Helberg
0 siblings, 1 reply; 5+ messages in thread
From: Eric Schulte @ 2014-01-08 16:58 UTC (permalink / raw)
To: Joost Helberg; +Cc: Org-Mode
Applied, thanks.
Joost Helberg <joost@snow.nl> writes:
> hi,
>
> the :colnames header argument is not honoured for postgresql. Hence the
> following patch for ob-sql.el. The command-line tool psql supports the
> option -t for not displaying column-names. The default behavious is not
> changed with this patch.
>
> 126,127c126
> < "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\" -f %s -o %s %s"
> < (if colnames-p "" "-t")
> ---
>> "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\" -f %s -o %s %s"
>
> Can anyone suggest to me why this should not be in ob-sql.el? It is
> already implemented for the mysql engine (via -N).
>
> regards,
>
> Joost
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch for ob-sql and postgresql for supporting :colnames
2014-01-08 16:58 ` Eric Schulte
@ 2014-02-03 13:11 ` Joost Helberg
2014-02-03 14:54 ` Bastien
0 siblings, 1 reply; 5+ messages in thread
From: Joost Helberg @ 2014-02-03 13:11 UTC (permalink / raw)
To: Eric Schulte; +Cc: Org-Mode
Eric,
it's not in org-plus-contrib-20140203. Was it lost somehow (also my fix
for stopping on error is not in)?
regards,
Joost
>>>>> "schulte" == schulte eric <schulte.eric@gmail.com> writes:
> From: schulte.eric@gmail.com
> To: joost@snow.nl
> Cc: emacs-orgmode@gnu.org
> Subject: Re: [O] patch for ob-sql and postgresql for supporting
> Date: 08-Jan-14 17:58
> Applied, thanks.
> Joost Helberg <joost@snow.nl> writes:
>> hi,
>>
>> the :colnames header argument is not honoured for postgresql. Hence the
>> following patch for ob-sql.el. The command-line tool psql supports the
>> option -t for not displaying column-names. The default behavious is not
>> changed with this patch.
>>
>> 126,127c126
>> < "psql --set=\"ON_ERROR_STOP=1\" %s -A -P footer=off -F \"\t\" -f %s -o %s %s"
>> < (if colnames-p "" "-t")
>> ---
>>> "psql --set=\"ON_ERROR_STOP=1\" -A -P footer=off -F \"\t\" -f %s -o %s %s"
>>
>> Can anyone suggest to me why this should not be in ob-sql.el? It is
>> already implemented for the mysql engine (via -N).
>>
>> regards,
>>
>> Joost
> --
> Eric Schulte
> https://cs.unm.edu/~eschulte
> PGP: 0x614CA05D
--
Snow B.V.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch for ob-sql and postgresql for supporting :colnames
2014-02-03 13:11 ` Joost Helberg
@ 2014-02-03 14:54 ` Bastien
2014-02-04 10:04 ` Joost Helberg
0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2014-02-03 14:54 UTC (permalink / raw)
To: Joost Helberg; +Cc: Org-Mode, Eric Schulte
Hi Joost,
Joost Helberg <joost@snow.nl> writes:
> it's not in org-plus-contrib-20140203. Was it lost somehow (also my fix
> for stopping on error is not in)?
The change you suggested is in the master branch, not in the maint
branch, which is for bugfixes only. IMO the change is more a feature
enhancement than a bugfix, hence the fact it's in master. Also, we
are more strict with "bugfixes" right now because all our fixes
will go into Emacs 24.4, which is in feature freeze right now.
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: patch for ob-sql and postgresql for supporting :colnames
2014-02-03 14:54 ` Bastien
@ 2014-02-04 10:04 ` Joost Helberg
0 siblings, 0 replies; 5+ messages in thread
From: Joost Helberg @ 2014-02-04 10:04 UTC (permalink / raw)
To: Bastien; +Cc: Org-Mode, Eric Schulte
Bastien,
OK, I understand.
regards,
Joost
>>>>> "bzg" == bzg <bzg@gnu.org> writes:
> From: bzg@gnu.org
> To: joost@snow.nl
> Cc: schulte.eric@gmail.com, emacs-orgmode@gnu.org
> Subject: Re: patch for ob-sql and postgresql for supporting :colnames
> Date: 03-Feb-14 15:54
> Hi Joost,
> Joost Helberg <joost@snow.nl> writes:
>> it's not in org-plus-contrib-20140203. Was it lost somehow (also my fix
>> for stopping on error is not in)?
> The change you suggested is in the master branch, not in the maint
> branch, which is for bugfixes only. IMO the change is more a feature
> enhancement than a bugfix, hence the fact it's in master. Also, we
> are more strict with "bugfixes" right now because all our fixes
> will go into Emacs 24.4, which is in feature freeze right now.
> --
> Bastien
--
Snow B.V.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-04 10:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-08 12:58 patch for ob-sql and postgresql for supporting :colnames Joost Helberg
2014-01-08 16:58 ` Eric Schulte
2014-02-03 13:11 ` Joost Helberg
2014-02-03 14:54 ` Bastien
2014-02-04 10:04 ` Joost Helberg
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).