Is Org mode gonna break on emacs 24.50.1x ?

Is Org mode gonna break on emacs 24.50.1x ?

[Baptiste Fouques]

Hi,

thanks all for org.

I  wonder  whether org-mode  is  going  to  break  badly on  next  emacs
cleanup.

---
commit 1e211d886c96420904ad197cfee7fce7ae7b9d83 (HEAD, refs/heads/master)
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date:   Fri Jun 22 09:42:38 2012 -0400

…
    * lisp/emacs-lisp/cl.el (flet): Don't autoload.
…
---

Makes  my  org not  working  in  several  places (babel,  coupling  with
remenber,  …).  I  think  that the  point in  using  'flet' has  appears
several times in this group. It seems to become more crucial here.

Don't think that the problem of emacs, but org …

Thanks.

-- 
~^v^~ Bat

Re: Is Org mode gonna break on emacs 24.50.1x ?

[Vladimir Lomov]

Hello,
** Baptiste Fouques [2012-06-25 17:38:22 +0200]:

> Hi,

> thanks all for org.

> I  wonder  whether org-mode  is  going  to  break  badly on  next  emacs
> cleanup.

IMHO, yes, see my message under topic 'Export and tangling is broken for
Emacs rev. 108681+' (actually it should be 'Export and tangling are
broken...')
http://article.gmane.org/gmane.emacs.orgmode/57278

> ---
> commit 1e211d886c96420904ad197cfee7fce7ae7b9d83 (HEAD, refs/heads/master)
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date:   Fri Jun 22 09:42:38 2012 -0400

> …
>     * lisp/emacs-lisp/cl.el (flet): Don't autoload.
> …
> ---

This is bzr rev. 108681

> Makes  my  org not  working  in  several  places (babel,  coupling  with
> remenber,  …).  I  think  that the  point in  using  'flet' has  appears
> several times in this group. It seems to become more crucial here.

> Don't think that the problem of emacs, but org …

> Thanks.

I'll wait the Org developers response.

---
WBR, Vladimir Lomov

-- 
I would like to urinate in an OVULAR, porcelain pool --

Re: Is Org mode gonna break on emacs 24.50.1x ?

[Achim Gratz]

Baptiste Fouques writes:
>     * lisp/emacs-lisp/cl.el (flet): Don't autoload.
>
> Makes  my  org not  working  in  several  places (babel,  coupling  with
> remenber,  …).  I  think  that the  point in  using  'flet' has  appears
> several times in this group. It seems to become more crucial here.

All the files using flet (and other cl macros) should have an

  (eval-when-compile (require 'cl))

before first use, so whether or not flet is autoloaded should be a moot
point.  If they don't, it's a bug in org.  If they do and it still
doesn't work, the bug may be in org, but more likely in Emacs.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

Re: Is Org mode gonna break on emacs 24.50.1x ?

[Vladimir Lomov]

Hello,
** Achim Gratz [2012-06-26 06:52:19 +0200]:

> Baptiste Fouques writes:
>>     * lisp/emacs-lisp/cl.el (flet): Don't autoload.

>> Makes  my  org not  working  in  several  places (babel,  coupling  with
>> remenber,  …).  I  think  that the  point in  using  'flet' has  appears
>> several times in this group. It seems to become more crucial here.

> All the files using flet (and other cl macros) should have an

>   (eval-when-compile (require 'cl))

> before first use, so whether or not flet is autoloaded should be a
> moot point.

I've searched the source (git actually) found where (require 'cl) is
used without `eval-when-compile' (just a few, htmlize.el is an example)
and changed them apropriately. Nothing changed, tangling is not working.

> If they don't, it's a bug in org.

> If they do and it still doesn't work, the bug may be in org, but more
> likely in Emacs.

So I dont' know where a bug is. I only know which rev. triggers it.

> Regards,
> Achim.

---
WBR, Vladimir Lomov

-- 
We didn't put in ^^ because then we'd have to keep telling people what
it means, and then we'd have to keep telling them why it doesn't short
circuit.  :-/
             -- Larry Wall in <199707300650.XAA05515@wall.org>

Re: Is Org mode gonna break on emacs 24.50.1x ?

[Vladimir Lomov]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

Hello,
** Achim Gratz [2012-06-26 06:52:19 +0200]:

> Baptiste Fouques writes:
>>     * lisp/emacs-lisp/cl.el (flet): Don't autoload.

>> Makes  my  org not  working  in  several  places (babel,  coupling  with
>> remenber,  …).  I  think  that the  point in  using  'flet' has  appears
>> several times in this group. It seems to become more crucial here.

> All the files using flet (and other cl macros) should have an

>   (eval-when-compile (require 'cl))

> before first use, so whether or not flet is autoloaded should be a moot
> point.  If they don't, it's a bug in org.  If they do and it still
> doesn't work, the bug may be in org, but more likely in Emacs.

I don't know if I understand what I do but I changed several `flet' to
`labels' (I read `cl.el' and they go consequently).

I post small patch that works for me, if it is ok (and I don't mess all
around) I can change all other `flet' (but I can't check them all).

> Regards,
> Achim.

Thanks again Achim, you point me in right direction (to change function
:).

P.S. Patch is bziped though it is small enough.

---
WBR, Vladimir Lomov

-- 
If you look good and dress well, you don't need a purpose in life.
		-- Robert Pante, fashion consultant

[-- Attachment #2: flet-labels.patch.bz2 --]
[-- Type: application/x-bzip2, Size: 4087 bytes --]

Re: Is Org mode gonna break on emacs 24.50.1x ?

[Eric Schulte]

This looks to be a bug in the most recent version of Emacs.
http://thread.gmane.org/gmane.emacs.devel/151211

Vladimir Lomov <lomov.vl@gmail.com> writes:

> Hello,
> ** Achim Gratz [2012-06-26 06:52:19 +0200]:
>
>> Baptiste Fouques writes:
>>>     * lisp/emacs-lisp/cl.el (flet): Don't autoload.
>
>>> Makes  my  org not  working  in  several  places (babel,  coupling  with
>>> remenber,  …).  I  think  that the  point in  using  'flet' has  appears
>>> several times in this group. It seems to become more crucial here.
>
>> All the files using flet (and other cl macros) should have an
>
>>   (eval-when-compile (require 'cl))
>
>> before first use, so whether or not flet is autoloaded should be a moot
>> point.  If they don't, it's a bug in org.  If they do and it still
>> doesn't work, the bug may be in org, but more likely in Emacs.
>
> I don't know if I understand what I do but I changed several `flet' to
> `labels' (I read `cl.el' and they go consequently).
>
> I post small patch that works for me, if it is ok (and I don't mess all
> around) I can change all other `flet' (but I can't check them all).
>
>> Regards,
>> Achim.
>
> Thanks again Achim, you point me in right direction (to change function
> :).
>
> P.S. Patch is bziped though it is small enough.
>
> ---
> WBR, Vladimir Lomov

-- 
Eric Schulte
http://cs.unm.edu/~eschulte

Re: Is Org mode gonna break on emacs 24.50.1x ?

[Achim Gratz]

Vladimir Lomov writes:
> I don't know if I understand what I do but I changed several `flet' to
> `labels' (I read `cl.el' and they go consequently).

The problem really is (or really was, it should be fixed) in Emacs
trunk.  Getting rid of unneccesary flet's would be nice on general
principle since flet does a couple of scary things, but we need to stay
backward compatible.  I don't know if labels is avilable (and works the
same) in XEmacs or in any Emacs before version 24...


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

DIY Stuff:
http://Synth.Stromeko.net/DIY.html

Re: Is Org mode gonna break on emacs 24.50.1x ?

[Bastien]

Achim Gratz <Stromeko@nexgo.de> writes:

> Vladimir Lomov writes:
>> I don't know if I understand what I do but I changed several `flet' to
>> `labels' (I read `cl.el' and they go consequently).
>
> The problem really is (or really was, it should be fixed) in Emacs
> trunk.  

Yes, apparently this has been fixed.

http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00515.html

Baptiste, can you confirm?

-- 
 Bastien

flet fixed in emacs trunk (Was: Is Org mode gonna break on emacs 24.50.1x ?)

[Baptiste Fouques]

Hi all,

thanks for your answers,
I do confirm  that 'flet' is now working in  emacs following emacs patch
http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00515.html

Org mode is working like a charm with in emacs, trunk version.

-- 
~^v^~ Bat

Baptiste Fouques <bateast@bat.fr.eu.org> writes:

> Hi,
>
> thanks all for org.
>
> I  wonder  whether org-mode  is  going  to  break  badly on  next  emacs
> cleanup.
>
> ---
> commit 1e211d886c96420904ad197cfee7fce7ae7b9d83 (HEAD, refs/heads/master)
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date:   Fri Jun 22 09:42:38 2012 -0400
>
> …
>     * lisp/emacs-lisp/cl.el (flet): Don't autoload.
> …
> ---
>
> Makes  my  org not  working  in  several  places (babel,  coupling  with
> remenber,  …).  I  think  that the  point in  using  'flet' has  appears
> several times in this group. It seems to become more crucial here.
>
> Don't think that the problem of emacs, but org …
>
> Thanks.

Re: flet fixed in emacs trunk

[Bastien]

Baptiste Fouques <bateast@bat.fr.eu.org> writes:

> I do confirm  that 'flet' is now working in  emacs following emacs patch
> http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00515.html
>
> Org mode is working like a charm with in emacs, trunk version.

Great, thanks for confirming!

-- 
 Bastien