emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch for testing `org-open-at-point'
Date: Tue, 03 Jun 2014 09:22:56 +0200	[thread overview]
Message-ID: <87tx83ul96.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87vbsjunua.fsf@Rainer.invalid> (Achim Gratz's message of "Mon,	02 Jun 2014 21:13:17 +0200")

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> Bastien writes:
>> Achim Gratz <Stromeko@nexgo.de> writes:
>>> Shouldn't the test check that the desired target is actually
>>> reached?
>>
>> That would be too complicated.  Checking that `org-open-at-point'
>> does not throw an error is enough IMO.
>
> I don't think so.  Implemented a check for that in 8e72c8fcfa.

Okay, thanks.  I pushed a small update, separating tests where we test
that `org-open-at-point' correctly opens the link at point, and tests
where we only tests that it correctly runs in a specific context.

-- 
 Bastien

      reply	other threads:[~2014-06-03  7:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11  1:34 Patch for testing `org-open-at-point' York Zhao
2014-04-11  7:23 ` Nicolas Goaziou
2014-04-11 10:25 ` Bastien
2014-04-12 14:22   ` York Zhao
2014-04-17 18:48     ` Bastien
2014-04-20 19:19       ` Michael Strey
2014-04-20 19:56       ` York Zhao
2014-06-01  1:12         ` York Zhao
2014-06-01  8:53           ` Bastien
2014-06-01 20:15           ` Achim Gratz
2014-06-01 21:14             ` Bastien
2014-06-01 21:58               ` babel C, C++, D enhancement Thierry Banel
2014-06-06 16:31                 ` Eric Schulte
2014-06-07 18:19                   ` Thierry Banel
2014-06-08 20:19                   ` Thierry Banel
2014-06-08 23:22                     ` Eric Schulte
2014-06-09  9:40                       ` Thierry Banel
2014-06-13  6:51                       ` Achim Gratz
2014-06-13 11:47                         ` Eric Schulte
2014-06-13 22:07                         ` Thierry Banel
2014-06-16 18:28                           ` Achim Gratz
2014-06-16 20:49                             ` Thierry Banel
2014-06-16 21:14                               ` Thomas S. Dye
2014-06-16 22:24                                 ` Nick Dokos
2014-06-17 17:16                               ` Achim Gratz
2014-06-17 20:51                                 ` Thierry Banel
2014-06-13 10:55                       ` Bastien
2014-06-13 11:58                         ` conforming commit messages Was: " Eric Schulte
2014-06-13 14:50                         ` Eric Abrahamsen
2014-06-02 19:13               ` Patch for testing `org-open-at-point' Achim Gratz
2014-06-03  7:22                 ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx83ul96.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).