Re: commit 4e864643 breaks org-return

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

"Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes:

> Mail von Stefan-W. Hahn, Thu, 22 Oct 2015 at 18:57:08 +0200:
>
> Hello,
>
>> commit 4e864643bdb6bba3e000ea51fb746a26e40b1f77
>> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> Date:   Sun Oct 18 09:36:15 2015 +0200
>> 
>> changes the behaviour of org-return when positioned right after a link with
>> org-return-follows-link set to t.
>
> the following patch seems to repair the behaviour:

But is the current behaviour broken in the first place? At least it is
consistent with `org-open-at-point' (C-c C-o).
>
> #+BEGIN_SRC elisp
> diff --git a/lisp/org.el b/lisp/org.el
> index a5183aa..3d527ac 100755
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -21354,7 +21354,9 @@ (defun org-return (&optional indent)
>       ((and org-return-follows-link
>            (or (org-at-timestamp-p t)
>                (org-at-date-range-p t)
> -              (org-in-regexp org-any-link-re)))
> +              (org-in-regexp org-any-link-re))
> +          (< (point)
> +             (org-element-property :end context)))

This wouldn't cut it because CONTEXT is wrong when, e.g., point is in
a comment. I think you're after the VISUALLY argument from
`org-in-regexp'. But then, it would require to turn
`org-at-date-range-p' and `org-at-timestamp-p' into `org-in-regexp'
calls.

Regards,

-- 
Nicolas Goaziou