From: Simon Thum <simon.thum@gmx.de>
To: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: commit 4e864643 breaks org-return
Date: Sun, 1 Nov 2015 23:19:44 +0000 [thread overview]
Message-ID: <56369E10.5060909@gmx.de> (raw)
In-Reply-To: <20151024064847.GA14197@pille.home>
Yes, absolutely, it's annnoying. This probably is the bug I reported a
day ago.
But in the past I observed this a bit differently:
Your description is correct, but there is/was a workaround: If you go to
x from the line below (i.e. press cursor left from the beginning of the
next line) it does/did not trigger. Any fix should probably be tested
against that trick too.
Cheers,
Simon
On 10/24/15 06:48, Stefan-W. Hahn wrote:
> Mail von Nicolas Goaziou, Sat, 24 Oct 2015 at 00:34:54 +0200:
>
> Hello,
>
>>>> commit 4e864643bdb6bba3e000ea51fb746a26e40b1f77
>>>> Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
>>>> Date: Sun Oct 18 09:36:15 2015 +0200
>>>>
>>>> changes the behaviour of org-return when positioned right after a link with
>>>> org-return-follows-link set to t.
>>>
>>> the following patch seems to repair the behaviour:
>>
>> But is the current behaviour broken in the first place? At least it is
>> consistent with `org-open-at-point' (C-c C-o).
>
> Yes. Yes.
>
> Before commit 4e86464 the behaviour was:
>
> [[link][description]]x
>
> with cursor at x hitting <RET> I got a line opened with cursor positioned
> at the beginning of the new line (or indented).
>
> But you are right, org-open-at-point with cursor at position x jumps
> to the link. This behaviour is not changed with the commit but I think
> this is also not the right behaviour. If you go with the mouse over the x
> then you don't get any popup from the link. For this you have to
> go at least over the last character "]" of the link resp. the visual "n"
> of the description. Even if you describe-text-properties with cursor at x
> you don't get any hint of the link. You have to go over the "]" (resp. "n")
> to see the link hint.
>
> From my point of view the commit 4e86464 changes the behaviour of org-return
> in a manner of which I think is not natural. org-open-at-point is, in my
> opinion, wrong in the same way because description says:
> "... When point is on a link, follow it."
> And being with cursor at x is obviously not "on a link".
>
> Any opinions from you or other org'ers?
>
> With kind regards,
> Stefan
>
prev parent reply other threads:[~2015-10-31 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 16:57 commit 4e864643 breaks org-return Stefan-W. Hahn
2015-10-23 20:07 ` Stefan-W. Hahn
2015-10-23 22:34 ` Nicolas Goaziou
2015-10-24 6:48 ` Stefan-W. Hahn
2015-10-25 16:41 ` Behaviour of org-open-at-point and org-return (was commit 4e864643 breaks org-return) Stefan-W. Hahn
2015-10-28 14:02 ` Matt Lundin
2015-10-31 22:38 ` Nicolas Goaziou
2015-11-01 23:19 ` Simon Thum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56369E10.5060909@gmx.de \
--to=simon.thum@gmx.de \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=stefan.hahn@s-hahn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).