From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Thum Subject: Re: commit 4e864643 breaks org-return Date: Sun, 1 Nov 2015 23:19:44 +0000 Message-ID: <56369E10.5060909@gmx.de> References: <20151022165708.GL12141@scotty.home> <20151023200734.GM12141@scotty.home> <87twphxlgx.fsf@nicolasgoaziou.fr> <20151024064847.GA14197@pille.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfRY-0001E5-Pv for emacs-orgmode@gnu.org; Sat, 31 Oct 2015 19:20:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsfRV-0001ht-L0 for emacs-orgmode@gnu.org; Sat, 31 Oct 2015 19:20:16 -0400 Received: from mout.gmx.net ([212.227.17.20]:51962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfRV-0001hn-Bh for emacs-orgmode@gnu.org; Sat, 31 Oct 2015 19:20:13 -0400 In-Reply-To: <20151024064847.GA14197@pille.home> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Stefan-W. Hahn" , Nicolas Goaziou Cc: emacs-orgmode@gnu.org Yes, absolutely, it's annnoying. This probably is the bug I reported a day ago. But in the past I observed this a bit differently: Your description is correct, but there is/was a workaround: If you go to x from the line below (i.e. press cursor left from the beginning of the next line) it does/did not trigger. Any fix should probably be tested against that trick too. Cheers, Simon On 10/24/15 06:48, Stefan-W. Hahn wrote: > Mail von Nicolas Goaziou, Sat, 24 Oct 2015 at 00:34:54 +0200: > > Hello, > >>>> commit 4e864643bdb6bba3e000ea51fb746a26e40b1f77 >>>> Author: Nicolas Goaziou >>>> Date: Sun Oct 18 09:36:15 2015 +0200 >>>> >>>> changes the behaviour of org-return when positioned right after a link with >>>> org-return-follows-link set to t. >>> >>> the following patch seems to repair the behaviour: >> >> But is the current behaviour broken in the first place? At least it is >> consistent with `org-open-at-point' (C-c C-o). > > Yes. Yes. > > Before commit 4e86464 the behaviour was: > > [[link][description]]x > > with cursor at x hitting I got a line opened with cursor positioned > at the beginning of the new line (or indented). > > But you are right, org-open-at-point with cursor at position x jumps > to the link. This behaviour is not changed with the commit but I think > this is also not the right behaviour. If you go with the mouse over the x > then you don't get any popup from the link. For this you have to > go at least over the last character "]" of the link resp. the visual "n" > of the description. Even if you describe-text-properties with cursor at x > you don't get any hint of the link. You have to go over the "]" (resp. "n") > to see the link hint. > > From my point of view the commit 4e86464 changes the behaviour of org-return > in a manner of which I think is not natural. org-open-at-point is, in my > opinion, wrong in the same way because description says: > "... When point is on a link, follow it." > And being with cursor at x is obviously not "on a link". > > Any opinions from you or other org'ers? > > With kind regards, > Stefan >