emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Remove redundant 'function's around lambda
Date: Wed, 18 Nov 2020 22:07:55 -0500	[thread overview]
Message-ID: <87tutm11tg.fsf@kyleam.com> (raw)
In-Reply-To: <CADwFkmkAUou5nT7fb1j2yj2cF4OdM=mLmZfKTJCBRCk0h7YZMA@mail.gmail.com>

Stefan Kangas writes:

> I've been working on removing redundant `function' around `lambda' in
> Emacs core, so here is a patch which does the same for Org-mode.


> Subject: [PATCH] Remove redundant 'function's around lambda
> diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el
> index 4a0cca612..da351ef82 100644
> --- a/lisp/ox-odt.el
> +++ b/lisp/ox-odt.el
> @@ -2200,10 +2200,10 @@ SHORT-CAPTION are strings."
>  (defun org-odt--image-size
>    (file info &optional user-width user-height scale dpi embed-as)
>    (let* ((--pixels-to-cms
> -          (lambda (pixels dpi)
> -            (let ((cms-per-inch 2.54)
> -                  (inches (/ pixels dpi)))
> -              (* cms-per-inch inches))))
> +	  (lambda (pixels dpi)
> +	    (let ((cms-per-inch 2.54)
> +		  (inches (/ pixels dpi)))
> +	      (* cms-per-inch inches))))

All these look good to me except this unrelated whitespace change, which
actually touches the change ported from your 61dca6e92a (Don't quote
lambdas in several places, 2020-11-14) in the Emacs repo.

Org files don't use a consistent style, despite Org's .dir-locals.el
setting indent-tabs-mode to t, which should probably be changed to match
Emacs's nil value.  At any rate, I've dropped this hunk since it's not
actually making the advertised change, and pushed the rest with

Thanks again.

  reply	other threads:[~2020-11-19  3:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 16:55 [PATCH] Remove redundant 'function's around lambda Stefan Kangas
2020-11-19  3:07 ` Kyle Meyer [this message]
2020-11-19  3:44   ` Stefan Kangas
2020-12-14  6:49   ` Bastien
2020-12-23  5:11     ` Kyle Meyer
2020-11-19 10:44 ` Neil Jerram
2020-11-19 14:51   ` Stefan Kangas
2020-11-19 15:16     ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tutm11tg.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=stefan@marxist.se \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).