From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QKvzIK7htV+qUwAA0tVLHw (envelope-from ) for ; Thu, 19 Nov 2020 03:08:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2PrJHK7htV8PPwAA1q6Kng (envelope-from ) for ; Thu, 19 Nov 2020 03:08:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED90A94011C for ; Thu, 19 Nov 2020 03:08:29 +0000 (UTC) Received: from localhost ([::1]:42058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfaJ8-0004OX-SO for larch@yhetil.org; Wed, 18 Nov 2020 22:08:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfaIk-0004OH-DY for emacs-orgmode@gnu.org; Wed, 18 Nov 2020 22:08:02 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:59120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfaIh-0004bg-O2 for emacs-orgmode@gnu.org; Wed, 18 Nov 2020 22:08:01 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D63BDA321E; Wed, 18 Nov 2020 22:07:56 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=ZAIblTZJwZGb0KXkZM/8lt362+g=; b=j+zaOl MNL+eT090EIE2cK+BYLCpRnMKzoMicq44oJnOnkbW+nJ6T8xHSorF9n+bg2vo2WM ttCALCDL7zoBNm/tqdzERI1IkkYOL2rytPBp6nzXpN8u8vFY0rNjsrCvBW6kCqRD PwGsze8MpikqT6fMfxFnTi2mRnnzU3u/GQq6Y= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CD36FA321D; Wed, 18 Nov 2020 22:07:56 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=1Cb5m9aMoIZHvc4mGbbSdXgfzO9DKsOETvu7CQF1fxY=; b=K7Gi32po4iVSZ1r7pOwbPMWNscRffC5QpGSXCPGP1+Mo9At4PpJnItvc82xQnEeVDsycpSKX/7ijsppnMh5tgjVq/gbgEPV7MUJBp0N+RLlGBI928wfrzsnQbIkDBjYuaeIm1d9M/9NyIkh9bS1rDGtBKgqrybFHiH+agqCgSzc= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 433A5A321C; Wed, 18 Nov 2020 22:07:56 -0500 (EST) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Stefan Kangas Subject: Re: [PATCH] Remove redundant 'function's around lambda In-Reply-To: References: X-Woof-Patch: applied Date: Wed, 18 Nov 2020 22:07:55 -0500 Message-ID: <87tutm11tg.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 6BE6276A-2A14-11EB-891A-D152C8D8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 22:07:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=j+zaOl M; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=K7Gi32po; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: BLTzhOfij0G9 Stefan Kangas writes: > I've been working on removing redundant `function' around `lambda' in > Emacs core, so here is a patch which does the same for Org-mode. Thanks. > Subject: [PATCH] Remove redundant 'function's around lambda [...] > diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el > index 4a0cca612..da351ef82 100644 > --- a/lisp/ox-odt.el > +++ b/lisp/ox-odt.el > @@ -2200,10 +2200,10 @@ SHORT-CAPTION are strings." > (defun org-odt--image-size > (file info &optional user-width user-height scale dpi embed-as) > (let* ((--pixels-to-cms > - (lambda (pixels dpi) > - (let ((cms-per-inch 2.54) > - (inches (/ pixels dpi))) > - (* cms-per-inch inches)))) > + (lambda (pixels dpi) > + (let ((cms-per-inch 2.54) > + (inches (/ pixels dpi))) > + (* cms-per-inch inches)))) All these look good to me except this unrelated whitespace change, which actually touches the change ported from your 61dca6e92a (Don't quote lambdas in several places, 2020-11-14) in the Emacs repo. Org files don't use a consistent style, despite Org's .dir-locals.el setting indent-tabs-mode to t, which should probably be changed to match Emacs's nil value. At any rate, I've dropped this hunk since it's not actually making the advertised change, and pushed the rest with 1a480e01a. Thanks again.