emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Allow org-capture-mode-hook to access org-capture-current-plist [9.3.6 (release_9.3.6-443-g0e8aff @ /home/n/.emacs.d/straight/build/org/)]
Date: Thu, 07 May 2020 21:53:00 +0200	[thread overview]
Message-ID: <87sggb5xpf.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r1w07w86.fsf@gmail.com> (No Wayman's message of "Sun, 03 May 2020 13:40:41 -0400")

Hello,

No Wayman <iarchivedmywholelife@gmail.com> writes:

> I'm proposing the following trivial patch to bring more consistency to
> org-capture-mode's hooks.
> By setting org-capture-current-plist before invoking org-capture-mode
> in the capture buffer, users
> can access the same variable in org-capture-mode-hook as they would in
> org-capture-before-finalize-hook and
> org-capture-prepare-finalize-hook.
> org-capture-after-finalize-hook is the only outlier, but that makes
> sense as the capture buffer is no longer current when it runs.

OK. 

Could you add the modified function in the commit message, add
TINYCHANGE cookie if you haven't signed FSF papers yet, and add an entry
in ORG-NEWS about it?

Regards,

-- 
Nicolas Goaziou


  reply	other threads:[~2020-05-07 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03 17:40 [PATCH] Allow org-capture-mode-hook to access org-capture-current-plist [9.3.6 (release_9.3.6-443-g0e8aff @ /home/n/.emacs.d/straight/build/org/)] No Wayman
2020-05-07 19:53 ` Nicolas Goaziou [this message]
2020-06-08 18:49   ` No Wayman
2020-06-10 17:43     ` Nicolas Goaziou
2020-06-11  6:31       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sggb5xpf.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).