emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: No Wayman <iarchivedmywholelife@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org, N V <iarchivedmywholelife@gmail.com>
Subject: Re: [PATCH] Allow org-capture-mode-hook to access org-capture-current-plist [9.3.6 (release_9.3.6-443-g0e8aff @ /home/n/.emacs.d/straight/build/org/)]
Date: Mon, 08 Jun 2020 14:49:57 -0400	[thread overview]
Message-ID: <875zc1bdey.fsf@gmail.com> (raw)
In-Reply-To: <87sggb5xpf.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Could you add the modified function in the commit message, add
> TINYCHANGE cookie if you haven't signed FSF papers yet, and add 
> an entry
> in ORG-NEWS about it?

I've modified the commit message and added an ORG-NEWS entry in 
the attached patch.
My FSF papers have recently cleared, so we should be good in that 

Nicholas Vollmer

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: set-org-capture-current-plist-before-org-capture-mode-hook --]
[-- Type: text/x-patch, Size: 1745 bytes --]

From 0590973aa7d487ed014ed6bcb5db6459b07218ab Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer <iarchivedmywholelife@gmail.com>
Date: Mon, 8 Jun 2020 14:19:35 -0400
Subject: [PATCH] lisp/org-capture.el: Set `org-capture-current-plist' before

* org-capture.el (org-capture-place-template): Allow `org-capture-current-plist' access during `org-capture-mode-hook'

Ensure consistency between org-capture's hooks.
`org-capture-after-finalize-hook' is now the only hook that cannot
access `org-capture-current-plst' because the capture buffer is killed
when it is run.
 etc/ORG-NEWS        | 1 +
 lisp/org-capture.el | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index f7c898f84..8db9db645 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -478,6 +478,7 @@ function, ~org-edit-latex-fragment~. This functions in a comparable
 manner to editing inline source blocks, bringing up a minibuffer set
 to LaTeX mode. The math-mode deliminators are read only.
+*** org-capture: ~org-capture-current-plist~ accessible during ~org-capture-mode-hook~
 * Version 9.3
 ** Incompatible changes
diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 9136d331b..7dde7e194 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -1128,8 +1128,8 @@ may have been stored before."
     (`plain (org-capture-place-plain-text))
     (`item (org-capture-place-item))
     (`checkitem (org-capture-place-item)))
-  (org-capture-mode 1)
-  (setq-local org-capture-current-plist org-capture-plist))
+  (setq-local org-capture-current-plist org-capture-plist)
+  (org-capture-mode 1))
 (defun org-capture-place-entry ()
   "Place the template as a new Org entry."

  reply	other threads:[~2020-06-08 18:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03 17:40 No Wayman
2020-05-07 19:53 ` Nicolas Goaziou
2020-06-08 18:49   ` No Wayman [this message]
2020-06-10 17:43     ` Nicolas Goaziou
2020-06-11  6:31       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zc1bdey.fsf@gmail.com \
    --to=iarchivedmywholelife@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --subject='Re: [PATCH] Allow org-capture-mode-hook to access org-capture-current-plist [9.3.6 (release_9.3.6-443-g0e8aff @ /home/n/.emacs.d/straight/build/org/)]' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).