Re: [PATCH] org-bibtex.el --- convert between Org headings and bibtex entries

[Matt Lundin <mdl@imapmail.org>]

Matt Lundin <mdl@imapmail.org> writes:

> "Eric Schulte" <schulte.eric@gmail.com> writes:
>> As one possible solution to this name conflict, I've folded my
>> org-bibtex.el into the existing org-bibtex.el in the Org-mode core.  The
>> attached patch performs this integration adding the functionality in my
>> version of org-bibtex.el into the Org-mode core.
>>
>> Does this seem like an appropriate addition?
>
> +1 (or maybe +.75 -- see below)
>
> I think this could finally tempt me to move all my bibliographical data
> into org-mode files. (I've been keeping all my data in a central bibtex
> file and using reftex to generate links to citations.)

I've been testing the patch and have a few comments. 

1. The prompt for the completing-read on line 440 is missing a space. It
   shows "Type:" rather than "Type: ".

2. In addition, since the symbols in org-bibtex-types are keywords, the
   completions are in the form ":article", ":book", etc. Might I ask why
   everything is org-bibtex-type is a keyword? Could we use strings or
   plain symbols instead? (Note: I haven't read the code carefully
   enough to see if there is a reason.)

3. The tooltip/help pop-up for org-bibtex-create takes up half a frame.

Thanks,
Matt