emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: Bernt Hansen <bernt@norang.ca>,
	Jacob Mitchell <jacob.d.mitchell@gmail.com>,
	org-mode List <emacs-orgmode@gnu.org>,
	Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: Re: [PATCH] Alphabetical ordered lists
Date: Mon, 20 Dec 2010 19:25:43 +0100	[thread overview]
Message-ID: <87pqswti6w.wl%n.goaziou@gmail.com> (raw)
In-Reply-To: <AANLkTikKteM9hg=015FSOVCEj3o8T78rWmY=tN67imrE@mail.gmail.com>

Hello,

>>>>> Nathaniel Flath writes:

> Sory for the long delay - I got caught up in other work. A
> patchaddressing the sisues brought up is attached.

I've had a look at your patch.

I think the modifications to HTML and DocBook exporters are nice. It
could be possible to do the same thing in LaTeX, but it would require
yet another package (enumitem) by default. Anyway, here are the code
comments :

- in your patch, you should try to list modifications to the
  functions, and which functions were created. For example :

  * org-list.el (org-alphabetical-lists): new variable
  (org-cycle-list-bullet): added "A)" "a)" "A." and "a." to the list
  of bullets in cycle. None of them is allowed in a description list.

- The "yes" at the beginning of org-docbook.el should be removed

- I advise against using (org-next-item) programmatically. It means
  you compute the structure associated to the list for each item in
  the list. I left a note about this circa line 847 in org-list.el

- There's a bug with the following situation :

  A) test
  B) tersi
  C) teirsu
  D) tersiu
  E) tesiu
  F) teisru
  G) etisu
     - sub-item 1
     - sub-item 2
     - sub-item 3
     - sub-item 4
  H) tesinu
  I) tesinru
  J) etnrsiu
  K) tesriun
  L) etnsiu
  M) estinu
  N) etsniu
  O) etsinu
  P) tesnu
  Q) etsinu
  R) etsiun
  S) etsnriu
  T) etsnriu
  U) etsinu
  V) etsiu
  W) etinrsu
  X) last item

  If you outdent sub-items 2 to 4 at the same time (with a region),
  bullet of the last item will become "AA)" and will not be recognized
  as a list item anymore.

- There's also a bug with counters:

  * [0/0] Counter

    A. [X] first box
    B. [X] second box

  These boxes are not counted when bullets are literals (try C-c #).


HTH,

Regards,

-- Nicolas

  reply	other threads:[~2010-12-20 18:27 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 20:27 [PATCH] Alphabetical ordered lists Nathaniel Flath
2010-07-29 21:07 ` Nick Dokos
2010-08-01 18:33   ` David Maus
2010-08-02  9:31 ` Nicolas Goaziou
2010-08-27  8:11 ` Carsten Dominik
2010-08-27 10:53   ` Bernt Hansen
2010-08-27 12:44     ` Jacob Mitchell
2010-08-27 13:01       ` Nathaniel Flath
2010-09-18  7:43         ` Nathaniel Flath
2010-09-21 12:48           ` Carsten Dominik
2010-09-21 16:46             ` Nicolas Goaziou
2010-09-26 17:36             ` Nicolas Goaziou
2010-09-26 22:16               ` Nathaniel Flath
2010-09-27  6:55                 ` Nicolas Goaziou
2010-09-28 16:12                   ` Carsten Dominik
2010-09-29 15:49                     ` Carsten Dominik
2010-09-29 16:50                       ` Nathaniel Flath
2010-09-29 17:46                       ` Nicolas Goaziou
2010-10-01  1:13                         ` Nathaniel Flath
2010-10-04  8:33                           ` Carsten Dominik
2010-10-04 17:18                             ` Nicolas Goaziou
2010-10-05  0:07                               ` Sebastian Rose
2010-10-05  0:21                                 ` Nathaniel Flath
2010-10-05  7:40                               ` Carsten Dominik
2010-10-21  4:44                                 ` Nathaniel Flath
2010-10-22  5:30                                   ` Nathaniel Flath
2010-10-22  8:13                                     ` Carsten Dominik
2010-10-23  1:04                                       ` Nathaniel Flath
2010-10-26  8:21                                     ` Nicolas Goaziou
2010-10-26  8:23                                       ` Carsten Dominik
2010-10-28  7:17                                         ` Nathaniel Flath
2010-11-11  7:16                                           ` Nathaniel Flath
2010-11-11  8:57                                             ` Nicolas Goaziou
2010-11-13 15:16                                             ` Nicolas Goaziou
2010-11-22  4:45                                               ` Nathaniel Flath
2010-11-22 13:37                                                 ` Bernt Hansen
2010-11-22 18:37                                                 ` Nicolas Goaziou
2010-11-27  4:39                                                   ` Nathaniel Flath
2010-12-11  2:41                                                     ` Nathaniel Flath
2010-12-20 18:25                                                       ` Nicolas Goaziou [this message]
2011-01-12 20:05                                                         ` Nathaniel Flath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqswti6w.wl%n.goaziou@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=bernt@norang.ca \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=flat0103@gmail.com \
    --cc=jacob.d.mitchell@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).