Possible issue with the Makefile

Possible issue with the Makefile

[Suvayu Ali]

Hi Achim,

While switching to the new exporter I noticed something.

In my local.mk I had `ORG_ADD_CONTRIB = org-e-*' before, but after the
switch I removed it (as you had pointed it out in another thread :)).
Despite that, all the org-e-* files under org-mode/lisp were not removed
after I did `make cleanall'.  I need to do a `git clean -f -x -e
local.mk' to get rid of them.

Don't you think this should be handled by the Makefile, or is this
non-trivial to deal with?

Thanks,

-- 
Suvayu

Open source is the future. It sets us free.

Re: Possible issue with the Makefile

[Achim Gratz]

Suvayu Ali writes:
> In my local.mk I had `ORG_ADD_CONTRIB = org-e-*' before, but after the
> switch I removed it (as you had pointed it out in another thread :)).
> Despite that, all the org-e-* files under org-mode/lisp were not removed
> after I did `make cleanall'.

You would have needed to do the "make clean" before the update that
renamed respectively moved those files if you use globbing patterns.

> Don't you think this should be handled by the Makefile, or is this
> non-trivial to deal with?

See above.  There is no way of knowing what the globbing pattern
expanded to after the files are no longer present in contrib/ and you
can't just go around in lisp/ and try the globbing there, at least not
if you don't want files to vanish at random.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

Re: Possible issue with the Makefile

[Suvayu Ali]

On Fri, Feb 08, 2013 at 11:17:28PM +0100, Achim Gratz wrote:
> Suvayu Ali writes:
> > In my local.mk I had `ORG_ADD_CONTRIB = org-e-*' before, but after the
> > switch I removed it (as you had pointed it out in another thread :)).
> > Despite that, all the org-e-* files under org-mode/lisp were not removed
> > after I did `make cleanall'.
> 
> You would have needed to do the "make clean" before the update that
> renamed respectively moved those files if you use globbing patterns.
> 
> > Don't you think this should be handled by the Makefile, or is this
> > non-trivial to deal with?
> 
> See above.  There is no way of knowing what the globbing pattern
> expanded to after the files are no longer present in contrib/ and you
> can't just go around in lisp/ and try the globbing there, at least not
> if you don't want files to vanish at random.
 
Thanks, I understand now :).  I'll put this in the FAQ.

Cheers,

-- 
Suvayu

Open source is the future. It sets us free.

Re: Possible issue with the Makefile

[Achim Gratz]

Suvayu Ali writes:
> Despite that, all the org-e-* files under org-mode/lisp were not removed
> after I did `make cleanall'.  I need to do a `git clean -f -x -e
> local.mk' to get rid of them.

The easier way of dealing with this would have been to either check out
maint and then do a "make clean" or do a "git clean lisp/" (since you
only wanted to remove files from under lisp/).

> Don't you think this should be handled by the Makefile, or is this
> non-trivial to deal with?

I've now arranged for this to be taken care of when using the update
targets, but you still have to remember to do it when you move the Git
HEAD from outside the build system across a commit that deletes, renames
or moves files that have been specified in ORG_ADD_CONTRIB.

Thank you for the suggestion.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada