Re: [ANN] Agenda speed up

[Eric S Fraga <esflists@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3427 bytes --]

On Sunday, 27 Aug 2017 at 18:16, Nicolas Goaziou wrote:
> Hello,
>
> I rewrote the part responsible for agenda generation in "org-agenda.el".
> Basically, I refactored some hot loops and introduced a cache mechanism
> for data extracted out of agenda files.
>
> I expect to see some interesting improvements when viewing the agenda
> with a span larger than one day, or when generating an agenda view
> without having touched most of the agenda files since last view.
>
> Some feedback about the new agenda speed would be nice.

Dear Nicolas,

thank you for this.  Speeding up the agenda is something that appeals
given the complexity of my agenda and the often need to view weeks or
months.

I've compared timings old with new (from git a few minutes ago) by
starting up emacs, instrumenting package org, viewing agenda (defaults
to 1 day), switching to month view and then moving to the following
month:

Old agenda:

| org-agenda-list               |     3 | 19.770361111 | 6.5901203703 |
| org-agenda-redo               |     2 | 18.346457274 | 9.1732286370 |
| org-let                       |     2 | 16.772160558 |  8.386080279 |
| org-agenda-get-day-entries    |   768 | 15.158740033 | 0.0197379427 |
| org-agenda-get-scheduled      |   768 | 9.5280991699 | 0.0124063791 |
| org-agenda-later              |     1 |  9.455895455 |  9.455895455 |
| org-agenda-view-mode-dispatch |     1 |  9.181260158 |  9.181260158 |
| org-agenda-month-view         |     1 |  8.891024524 |  8.891024524 |
| org-agenda-change-time-span   |     1 |  8.891016702 |  8.891016702 |
| org-agenda-prepare-buffers    |     5 | 5.8218686260 | 1.1643737252 |
| org-agenda-prepare            |     3 | 4.4909116949 | 1.4969705649 |
| org-at-planning-p             | 38979 | 3.8525446340 | 9.883...e-05 |
| org-agenda                    |     1 |  3.198932055 |  3.198932055 |

New agenda:

| org-agenda-list               |      3 | 29.473988928 |  9.824662976 |
| org-agenda-redo               |      2 | 28.332199373 | 14.166099686 |
| org-let                       |      2 | 25.852282215 | 12.926141107 |
| org-agenda-day-entries        |    768 | 25.210189072 | 0.0328257670 |
| org-agenda-view-mode-dispatch |      1 | 14.441177311 | 14.441177311 |
| org-agenda-month-view         |      1 | 14.281358385 | 14.281358385 |
| org-agenda-change-time-span   |      1 | 14.281353565 | 14.281353565 |
| org-agenda-later              |      1 | 14.051216182 | 14.051216182 |
| org-back-to-heading           | 110331 | 9.5532106970 | 8.658...e-05 |
| org-get-todo-state            |  96677 | 9.5383469060 | 9.866...e-05 |
| org-agenda-skip               |  97251 | 8.0815792529 | 8.310...e-05 |
| org-agenda-prepare-buffers    |      5 | 5.7887248999 |   1.15774498 |
| org-agenda-prepare            |      3 |  4.180059331 | 1.3933531103 |
| org-agenda                    |      1 |  3.805856309 |  3.805856309 |
| org-agenda-to-appt            |      2 |  2.477811826 |  1.238905913 |
| org-get-agenda-file-buffer    |    888 | 1.8626567679 | 0.0020975864 |

I had to remove a bunch of <%% (...)> items in one of my agenda files as
these gave me error messages about the sexp.

Finally, most importantly, the actual items shown in the day view with
the new code are only a subset of those shown with the old view.  I
cannot see any pattern in those omitted.

Thanks again,
eric

-- 
: Eric S Fraga via Emacs 26.0.50, Org release_9.0.9-796-gbae41a

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 194 bytes --]