From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [ANN] Agenda speed up
Date: Mon, 28 Aug 2017 16:24:50 +0200 [thread overview]
Message-ID: <878ti3srbh.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87o9r0uhl2.fsf@t3610> (Eric S. Fraga's message of "Mon, 28 Aug 2017 11:12:09 +0100")
Hello,
Eric S Fraga <esflists@gmail.com> writes:
> I've compared timings old with new (from git a few minutes ago) by
> starting up emacs, instrumenting package org, viewing agenda (defaults
> to 1 day), switching to month view and then moving to the following
> month:
>
> Old agenda:
>
> | org-agenda-list | 3 | 19.770361111 | 6.5901203703 |
[...]
> New agenda:
>
> | org-agenda-list | 3 | 29.473988928 | 9.824662976 |
How great! I managed to achieve a negative speed up.
> | org-agenda-skip | 97251 | 8.0815792529 | 8.310...e-05 |
I overlooked `org-agenda-skip', which does nothing fancy on my side. It
is indeed called more often...
Skipping is actually harder with the cache, because you want to cache
everything anyway (or the cache cannot be trusted).
> I had to remove a bunch of <%% (...)> items in one of my agenda files as
> these gave me error messages about the sexp.
Could you show one of the culprits?
> Finally, most importantly, the actual items shown in the day view with
> the new code are only a subset of those shown with the old view. I
> cannot see any pattern in those omitted.
There may be more than one pattern involved. Maybe the types involved
would help.
I updated the "wip-agenda-speedup" branch (rebasing needed). It should
now call `org-agenda-skip' less often. Could you try again using that?
Thank you for the feedback.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-08-28 14:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 16:16 [ANN] Agenda speed up Nicolas Goaziou
2017-08-27 16:22 ` Nicolas Goaziou
2017-08-27 20:05 ` Samuel Wales
2017-08-31 17:17 ` Nicolas Goaziou
2017-08-27 20:53 ` Russell Adams
2017-08-28 8:32 ` Colin Baxter
2017-08-28 10:12 ` Eric S Fraga
2017-08-28 14:24 ` Nicolas Goaziou [this message]
2017-08-29 6:52 ` Eric S Fraga
2017-08-29 15:56 ` Robert Horn
2017-08-29 8:06 ` Eric S Fraga
2017-08-30 9:00 ` Nicolas Goaziou
2017-08-30 9:41 ` Eric S Fraga
2017-08-30 15:00 ` Nicolas Goaziou
2017-08-30 15:37 ` Eric S Fraga
2017-08-30 9:42 ` Eric S Fraga
2017-09-29 20:45 ` Nicolas Goaziou
2017-09-29 20:56 ` Samuel Wales
2017-09-30 8:55 ` Nicolas Goaziou
2017-09-30 19:03 ` Matt Lundin
2017-10-01 17:33 ` Nicolas Goaziou
2017-10-01 17:57 ` Samuel Wales
2017-10-01 17:58 ` Samuel Wales
2017-10-01 22:59 ` Nicolas Goaziou
2017-10-01 23:49 ` Matt Lundin
2017-09-30 3:20 ` Kyle Meyer
2017-10-02 13:41 ` Nicolas Goaziou
2017-10-05 14:48 ` Kyle Meyer
2017-09-30 18:54 ` Matt Lundin
2017-09-30 19:53 ` Matt Lundin
2017-10-01 17:13 ` Nicolas Goaziou
2017-10-02 0:11 ` Matt Lundin
2017-10-02 0:39 ` Samuel Wales
2017-10-02 15:46 ` Nicolas Goaziou
2017-10-02 18:11 ` Marco Wahl
2017-10-03 9:35 ` Nicolas Goaziou
2017-10-03 10:23 ` Marco Wahl
2017-10-02 20:39 ` Samuel Wales
2017-10-03 9:36 ` Nicolas Goaziou
2017-10-03 23:45 ` Samuel Wales
2017-10-04 0:05 ` Samuel Wales
2017-10-02 15:28 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ti3srbh.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).